Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"applicable" columns are confusing. #1027

Open
rajeee opened this issue Feb 3, 2023 · 2 comments
Open

"applicable" columns are confusing. #1027

rajeee opened this issue Feb 3, 2023 · 2 comments

Comments

@rajeee
Copy link
Contributor

rajeee commented Feb 3, 2023

Currently, for a baseline run, ResStock outputs the following combination of "applicable" columns.

image

So, when the run is completed successfully, the report_simulation_output.applicable is set to True but simulation_output_report.applicable is None. Which seems inconsistent. The values of other columns make sense.

For upgrade run, the possible set of combinations are as follows (as seen in a 550K upgrade run):

image

Same issue with simulation_output_report.applicable vs report_simulation_output.applicable for successful run.

For Invalid runs, which is supposed to indicate that a building is not a part of an upgrade and no simulation is done for that,
Only the "simulation_output_report.applicable" is False. I would have expected all the columns to be False.
joseph-robertson added a commit that referenced this issue Feb 3, 2023
@joseph-robertson
Squashed 'resources/hpxml-measures/' changes from b3afe1c1fe08..9be6b…
ed2cd34 
…48fb6c9

9be6b48fb6c9 Merge pull request #1027 from NREL/foundation-floor-area
fcb76b8aa1f0 Use new method throughout test.
89ecff3bb5e3 Add test for various foundations.
689cf5ff2086 Exclude garages from foundation floors.
62bf4d1d56ef Foundation slab could be at grade.
d85026c649a1 Update the changelog.
d7494630ba16 Update docs.
c94657aa98f8 Update tests.
cc7aa49ba455 Add new multiplier to measure and constants.
5c0bd9b56438 Merge pull request #1012 from NREL/additional-properties-updates
8fa43c9bb448 Update Changelog.md
2569aeb17804 Minor cleanup. Reverts EPvalidator.xml and docs changes.
39032492560d Latest results.
5717b02e84a1 Merge branch 'master' into additional-properties-updates
eab2693294df Update description and docs.
a0176f01e5cb Merge pull request #1010 from NREL/fix_timeseries_emissions
15dc8bc1f0b0 Latest results.
3961f4dfd771 Update Changelog.md [ci skip]
6e981e11bc0a Latest results.
c8ea2273a98e Test more characters.
dea7fa60c414 Latest results.
ddc83ef99c93 Merge branch 'master' into additional-properties-updates
b5d2f37c644f Fixes and updates to tear down method.
63df131dbb14 Add convenience method for retrieving additional properties.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 9be6b48fb6c978358cc8e942001ac2b2a9586eae
joseph-robertson pushed a commit that referenced this issue Feb 3, 2023
@shorowit
Squashed 'resources/hpxml-measures/' changes from a635749cb4..75f0bdb867
a28c6a7 
75f0bdb867 Bump to dev-3.4.0-rc1
b17dc85a4d Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into os340
b17cbb27bf Merge pull request #1033 from NREL/dfhp_bugfix
46f2b81e60 DFHP bugfix.
a4fbdc2af5 Merge pull request #1013 from NREL/end-use-heating-hp-backup
424e3928ee One more fix [ci skip]
82413f9aa8 Escape characters [ci skip]
d1b9f2be37 DFHP bugfix, take 2.
ffe500b410 DFHP bugfix.
7fd8911e7d Forgot to save.
c76b9ef8ca Expand workflow tests to separately check for backup heating energy use. And a little DFHP code simplification.
41bd7f8db9 Merge branch 'end-use-heating-hp-backup' of https://github.com/NREL/OpenStudio-HPXML into end-use-heating-hp-backup
74456edfb5 Update Changelog.md; call out as a breaking change. [ci skip]
56b27af87d Latest results.
7b3511e9ab Merge branch 'end-use-heating-hp-backup' of https://github.com/NREL/OpenStudio-HPXML into end-use-heating-hp-backup
ec412111ec Bugfixes for GSHPs & DFHPs.
f002a270ea Latest results.
6dd88bdc4f Latest results.
87d0eef35e Merge branch 'end-use-heating-hp-backup' of https://github.com/NREL/OpenStudio-HPXML into end-use-heating-hp-backup
a79f9390aa Fix for heat pump with integrated backup. Minor code cleanup.
83aa5846fe Update the changelog.
c05656e5d0 Slightly different approach.
01541b4f89 Merge branch 'master' into end-use-heating-hp-backup
d3a3bd73ba Fix documentation of equations for LULs. [ci skip]
c27c3f988c Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into os340
3c97699a14 Merge pull request #1032 from NREL/ventilation_fan_used_for
2597d49790 Add comments.
189a13c8c9 Refactor/simplify code.
13882bdb96 Clarify docs [ci skip]
bc717ccaa2 Need to retain range electricity use even if range is not in conditioned space.
5982a14cbe Narrower focus of bugfix.
b58e065cf4 Update measures
4f1fbf874f Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ventilation_fan_used_for
9be6b48fb6 Merge pull request #1027 from NREL/foundation-floor-area
cf8ed1c474 Require one (and only one) `VentilationFan` UsedForFoo element. Fixes range/dryer ventilation interaction with infiltration to take into account the appliance's location (conditioned vs unconditioned space).
fcb76b8aa1 Use new method throughout test.
89ecff3bb5 Add test for various foundations.
689cf5ff20 Exclude garages from foundation floors.
62bf4d1d56 Foundation slab could be at grade.
d85026c649 Update the changelog.
d7494630ba Update docs.
c94657aa98 Update tests.
cc7aa49ba4 Add new multiplier to measure and constants.
7a754f00f6 Revert "Check that errors are now caught."
cf9522fe67 Merge branch 'os340' of https://github.com/NREL/OpenStudio-HPXML into os340
48d6d8d926 Check that errors are now caught.
0f5d1c54c6 Latest results.
b11fbdf61c Latest results.
af70848904 Merge branch 'master' into end-use-heating-hp-backup
4accda1d44 Latest results.
5ae6123e7f Start updating docs.
88a1c2c544 Add hp backup to energy_htg.
1f4ca993e9 Clean up.
03fef77386 Support more backup types.
cd5d1f8668 Update expected test outputs.
8879e12348 Use bool as switch for new end use output.
e77d0f6b2e Store bool supplemental coil additional property.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 75f0bdb8674f41caf3df9785278f98acc65c9e9f
@joseph-robertson
Copy link
Contributor

Is this actually a buildstockbatch issue?

@rajeee
Copy link
Contributor Author

rajeee commented Feb 8, 2023 •
edited
Loading

We can ignore the applicable columns in the buildstockbatch since "completed_status" column contains all the info we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joseph-robertson @rajeee