Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate detailed utility bills #988

Closed
joseph-robertson opened this issue Sep 15, 2022 · 6 comments · Fixed by #1109
Closed

Calculate detailed utility bills #988

joseph-robertson opened this issue Sep 15, 2022 · 6 comments · Fixed by #1109
Assignees
@joseph-robertson

Comments

@joseph-robertson
Copy link
Contributor

Pull in detailed utility bill calculation capabilities from OS-HPXML: NREL/OpenStudio-HPXML#1092
@joseph-robertson joseph-robertson mentioned this issue Oct 5, 2022
Closed
@afontani
Copy link
Contributor

Waiting on the OpenStudio-HPXML PR to get merged before pulling into ResStock.

@afontani
Copy link
Contributor

@joseph-robertson : Are we able to pull this feature into ResStock now?

@joseph-robertson
Copy link
Contributor Author

@afontani Yes we are.

@afontani
Copy link
Contributor

The next steps are to design YAML and update the workflow generator in BuildStock-Batch. Possibly like Cambium. Considerations around multiple utilities and thus rates for a given geography.

@joseph-robertson
Copy link
Contributor Author

joseph-robertson commented Nov 17, 2022 •
edited
Loading

My first cut at a design. Here are several scenarios (i.e., possible options) I envision for a user requesting detailed utility bills:

    utility_bills:
      - scenario_name: BillsDetailedEIAID
        calc_type: detailed
        # like emissions, i'm envisioning using a TSV as a lookup
        # from sampling this TSV you'd get, say, EIAID (utility ID)
        # utility ID would map to a specific tariff.json

      - scenario_name: BillsDetailedSpecified1
        calc_type: detailed
        elec_detailed_filepath: path/to/tariff.json
        # tariff.json is applied to all samples

      - scenario_name: BillsDetailedSpecified2
        elec_detailed_filepath: path/to/tariff.json
        # presence of this field means calc_type detailed
        # tariff.json is applied to all samples

@afontani @shorowit @ekpresent

joseph-robertson added a commit that referenced this issue Feb 3, 2023
@joseph-robertson
Squashed 'resources/hpxml-measures/' changes from 2224e6cfcf9..fda505…
d9fbe45 
…a8d95

fda505a8d95 Update measure argument description.
5ea2342916f Update changelog and docs.
a63142a44f7 Add reporting test for advanced output variables.
f574c52e842 Add reporting test and update template osw.
18193edc885 Add new optional argument for output variables.
602378b40ca Merge pull request #1001 from NREL/eri_reporting
ce9a1a6b90e Latest results.
1a9b90987d5 Increase number of output decimal places and a little code cleanup.
c67d0f7a780 Update xml
59bab55d0bf EC bugfix.
66d21ad412d Refactor/simplify ReportSimulationOutput for ERI purposes. No longer creates a separate *_ERI.csv.
0457f4db9f9 Revert "Add HPXML has_fuel helper method."
365c8e2fcdd Add HPXML has_fuel helper method.
c8b56ceb83a Fix case.
67e93b0c152 Clarify documentation for interior surfaces (or flat roofs) regarding Azimuth/Orientation defaulting.
a7f6341d493 Merge pull request #999 from NREL/shared_recirc_temperature
d5fc0daed83 Drop ABCDE
4bb47a2d00a Updated xml
5c3c071f772 Adds support for shared hot water recirculation systems controlled by temperature, per ANSI/RESNET/ICC 301-2019 Addendum C.
916014c91c8 Merge pull request #996 from NREL/battery-docs
48503939ee9 Merge pull request #995 from NREL/fossil_fuel_emissions_factors
d0a9528e078 Minor tweak.
9c4727d50e7 Adds some explanation for how batteries are controlled and other misc cleanup.
6d9edb4f618 Latest results.
e0369eb925d Rename "CO2" to "CO2e". Updated cambium data to be CO2e and combined (combustion + pre-combustion).
6c9cd855816 Updated default fossil fuel emissions factors to include pre-combustion (e.g., methane leakage for natural gas).
58bccc6420c Merge pull request #992 from NREL/minitest_helper2
9b7ce3f3c02 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into minitest_helper2
6a451ecdb45 Revert to original config
713fb844c91 Merge pull request #993 from NREL/goodbye_beta
bfa2365a843 Remove the "Beta" label from the BuildResidentialHPXML measure. [ci skip]
f5729c759b8 Aha, this test file was not loading minitest_helper.rb.
77ca82d4152 Try excluding build_residential_hpxml_test.rb
854d4ccb090 First, reproduce issue on CI.
d174ace1df1 Merge pull request #987 from NREL/hvac_iq_limits
9d40f9e25e6 Update Changelog.md [ci skip]
7a1644d70e9 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_iq_limits
06bd81964cc Merge pull request #986 from NREL/docs_on_ci
afe5d64f823 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into docs_on_ci
e5de16e128d Merge pull request #988 from NREL/minitest_helper
66bf8248d02 Possible fix to obtain code coverage on CI?
e6ee2daa0cb Try reverting minitest_helper.rb change.
33b4d180cf9 Adds more stringent limits for `AirflowDefectRatio` and `ChargeDefectRatio` (-0.9 to 9, which now allows values from 1/10th to 10x the design value).
f1c13fb6871 Re-enable CI steps
913f947f19a Fix error?
3c21bf713a8 Install pip
3afc9dcf5c0 Install sphinx
f8e4ca4a4c8 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into docs_on_ci
f0844a93edf Merge pull request #978 from NREL/leap-year-handling
040604b1106 Add newline
44224c6a06d Build docs on CI, store as artifacts.
852a36d084f Update workflow test file.
bc8ccc2868a Update error test.
219cbdfee88 Update error message.
69319016c04 Update changelog and docs.
f782deade4f Merge branch 'master' into leap-year-handling
39686d9de69 Merge pull request #980 from NREL/report-sim-output-setup-fix
a80a1f25183 Return if model not retrieved.
6dd4463a51d Latest results.
335370e3c0b Update defaults header test.
bbd8c3bcc1a Add test for throwing error.
24936969f9e Throw error if leap year with TMY.
14519b064f5 Clean up translator measure.
c7a8ad6a2ef Change to non leap year in test xml file.
6a1ea0ad3ba Update README.md

git-subtree-dir: resources/hpxml-measures
git-subtree-split: fda505a8d95267aaee4f8ae832f338f321981d00
joseph-robertson added a commit that referenced this issue Feb 3, 2023
@joseph-robertson
Squashed 'resources/hpxml-measures/' changes from 2224e6cfcf9..75de13…
798445f 
…f619e

75de13f619e Simpler fix to negative peak/design values.
51dbd82f910 Merge pull request #1007 from NREL/negative_peak_flow_rate
f5ee3eee6a6 Prevent possibility of trying to set, e.g., negative peak flow rate.
0a561c1369e Merge pull request #1006 from NREL/door_bugfix
b5440086603 Bugfix for cases where door R-value w/o air film goes negative. (Can occur for, e.g., CZ 1 where IECC door U-factor is 1.2.)
602378b40ca Merge pull request #1001 from NREL/eri_reporting
ce9a1a6b90e Latest results.
1a9b90987d5 Increase number of output decimal places and a little code cleanup.
c67d0f7a780 Update xml
59bab55d0bf EC bugfix.
66d21ad412d Refactor/simplify ReportSimulationOutput for ERI purposes. No longer creates a separate *_ERI.csv.
0457f4db9f9 Revert "Add HPXML has_fuel helper method."
365c8e2fcdd Add HPXML has_fuel helper method.
c8b56ceb83a Fix case.
67e93b0c152 Clarify documentation for interior surfaces (or flat roofs) regarding Azimuth/Orientation defaulting.
a7f6341d493 Merge pull request #999 from NREL/shared_recirc_temperature
d5fc0daed83 Drop ABCDE
4bb47a2d00a Updated xml
5c3c071f772 Adds support for shared hot water recirculation systems controlled by temperature, per ANSI/RESNET/ICC 301-2019 Addendum C.
916014c91c8 Merge pull request #996 from NREL/battery-docs
48503939ee9 Merge pull request #995 from NREL/fossil_fuel_emissions_factors
d0a9528e078 Minor tweak.
9c4727d50e7 Adds some explanation for how batteries are controlled and other misc cleanup.
6d9edb4f618 Latest results.
e0369eb925d Rename "CO2" to "CO2e". Updated cambium data to be CO2e and combined (combustion + pre-combustion).
6c9cd855816 Updated default fossil fuel emissions factors to include pre-combustion (e.g., methane leakage for natural gas).
58bccc6420c Merge pull request #992 from NREL/minitest_helper2
9b7ce3f3c02 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into minitest_helper2
6a451ecdb45 Revert to original config
713fb844c91 Merge pull request #993 from NREL/goodbye_beta
bfa2365a843 Remove the "Beta" label from the BuildResidentialHPXML measure. [ci skip]
f5729c759b8 Aha, this test file was not loading minitest_helper.rb.
77ca82d4152 Try excluding build_residential_hpxml_test.rb
854d4ccb090 First, reproduce issue on CI.
d174ace1df1 Merge pull request #987 from NREL/hvac_iq_limits
9d40f9e25e6 Update Changelog.md [ci skip]
7a1644d70e9 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac_iq_limits
06bd81964cc Merge pull request #986 from NREL/docs_on_ci
afe5d64f823 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into docs_on_ci
e5de16e128d Merge pull request #988 from NREL/minitest_helper
66bf8248d02 Possible fix to obtain code coverage on CI?
e6ee2daa0cb Try reverting minitest_helper.rb change.
33b4d180cf9 Adds more stringent limits for `AirflowDefectRatio` and `ChargeDefectRatio` (-0.9 to 9, which now allows values from 1/10th to 10x the design value).
f1c13fb6871 Re-enable CI steps
913f947f19a Fix error?
3c21bf713a8 Install pip
3afc9dcf5c0 Install sphinx
f8e4ca4a4c8 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into docs_on_ci
f0844a93edf Merge pull request #978 from NREL/leap-year-handling
040604b1106 Add newline
44224c6a06d Build docs on CI, store as artifacts.
852a36d084f Update workflow test file.
bc8ccc2868a Update error test.
219cbdfee88 Update error message.
69319016c04 Update changelog and docs.
f782deade4f Merge branch 'master' into leap-year-handling
39686d9de69 Merge pull request #980 from NREL/report-sim-output-setup-fix
a80a1f25183 Return if model not retrieved.
6dd4463a51d Latest results.
335370e3c0b Update defaults header test.
bbd8c3bcc1a Add test for throwing error.
24936969f9e Throw error if leap year with TMY.
14519b064f5 Clean up translator measure.
c7a8ad6a2ef Change to non leap year in test xml file.
6a1ea0ad3ba Update README.md

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 75de13f619e9b4b98f7f33889caf8de406f6ea07
@joseph-robertson
Copy link
Contributor Author

joseph-robertson commented Jul 18, 2023 •
edited
Loading

After some discussion, the plan is to follow #1012:

  • introduce new optional detailed_filepath that points to TSV file with utility rate JSON file paths
  • the YML looks like, e.g., detailed_filepath: data/detailed_rates/County.tsv
  • the TSV has columns: <parameter>, electricity_filepath, then xxx_fixed_charge and xxx_marginal_rate for all fuels (not electricity)
  • improve buildstockbatch documentation around simple_filepath and detailed_filepath YML arguments

@joseph-robertson joseph-robertson self-assigned this Jul 18, 2023
@joseph-robertson joseph-robertson mentioned this issue Jul 24, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joseph-robertson joseph-robertson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Calculate detailed utility bills NREL/resstock
2 participants
@joseph-robertson @afontani