Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to RECS 2020 data #1031

Merged
merged 115 commits into from
Jun 8, 2023
Merged

Update to RECS 2020 data #1031

merged 115 commits into from
Jun 8, 2023

Conversation

afontani
Copy link
Contributor

@afontani afontani commented Feb 23, 2023 •
edited by joseph-robertson
Loading

Pull Request Description

Companion PR: ResStock-Estimation #323

Transitioning characteristics to use the EIA's 2020 RECS survey final characteristics. The development effort had the following goals:

Goals of the effort:

  • Include Alaska and Hawaii into ResStock
  • Include State level characteristics differentiation instead of previous multi-state regions
  • Differentiate characteristics of mobile homes from single-family detached homes
  • Include income and tenure correlations to characteristic saturation and efficiency levels

Characteristics that use the 2020 RECS data:

  • Clothes Dryer
  • Clothes Washer
  • Clothes Washer Presence
  • Cooking Range
  • Cooling Setpoint
  • Cooling Setpoint Has Offset
  • Cooling Setpoint Offset Magnitude
  • Cooling Setpoint Offset Period
  • Dishwasher
  • Geometry Attic Type
  • HVAC Cooling Efficiency
  • HVAC Cooling Type
  • HVAC Has Ducts
  • HVAC Has Shared System
  • HVAC Heating Efficiency
  • HVAC Heating Type
  • HVAC Heating Type And Fuel
  • HVAC Shared Efficiencies
  • Heating Setpoint
  • Heating Setpoint Has Offset
  • Heating Setpoint Offset Magnitude
  • Heating Setpoint Offset Period
  • Misc Extra Refrigerator
  • Misc Freezer
  • Misc Hot Tub Spa
  • Misc Pool
  • Misc Pool Heater
  • Refrigerator
  • Roof Material
  • Water Heater Efficiency
  • Water Heater Fuel
  • Water Heater In Unit
  • Windows

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

@afontani
Update characteristics from RECS 2020
b07a9da
@afontani
Couple option_lookup changes
3291d4f
@afontani
Fix options_lookup dishwasher
8035f61
@afontani
More option_lookup fixes from RECS 2020
0a4aa98
@afontani
Options lookup changes
f3fec7f
@afontani
Remove Geometry Ceiling Height.tsv from project_testing
d010ab0
@afontani
Remove Schedules.tsvs
1ad09ad
@afontani
Typo missing ResStockArguments column
00494a3
@afontani
Add County and PUMA AK,HI entries
9a92107
@afontani
Placeholder for low slope roofs
f045709
@afontani
CEC Climate Zone file missing AK County and PUMA entry
3ab5d3c
@afontani
Add AK and HI to State in options lookup
17cf03f
@afontani
AK, HI in ReEDS BA and GEA
eee2f18
@afontani
AK, HI in Climate Zones
d0cdc81
@afontani
Location Region Option=None
32fa4b7
@afontani
Add AK climate zones to Geometry Foundation Type
94078b4
@afontani
Update from recs2020-develop
86e2377
@afontani
Update location region with AK and HI split out
e2a36b4
@afontani
Insulation CRAK and KI. Turn on AK and HI in RECS 2020
e114ff6
@afontani
Add Rows for PV in AK and HI (Assumption: No PV in AK and HI. No data.)
1de289f
@afontani
Add Location Region CRAK and CRHI to options lookup
c7aa01f
@afontani
Add None and Void Options to Heating/Cooling Setpoints in options_lookup
7aae85a
@afontani
Add Dishwasher Void and remove arguments from other Void options
7a38d67
@afontani
More Void options
7b30d7a
@afontani
More void
eeab800
@afontani
Add 7AK and 8AK to Infiltration
0f56e2a
@afontani
Add counter to integrity checks
e5bb807
@afontani
Fix missing Electric Wall Furnace in HVAC Heating Efficiency
142b2a6
@afontani
Add AK and HI to Lightbox characteristics
88f56f1
@afontani
Merge remote-tracking branch 'origin/develop' into recs2020_develop
b2b4d87
@afontani afontani self-assigned this May 31, 2023
@afontani
Copy link
Contributor Author

Can we add a changelog entry for this?

@joseph-robertson : Done. 2ca14ec

joseph-robertson
joseph-robertson reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@joseph-robertson joseph-robertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should n_buildings_represented in the project ymls be updated (since adding AK/HI)?

Because integration test samples change, how do / should we check for regressions?

project_national/national_upgrades.yml Show resolved Hide resolved
project_national/national_upgrades.yml Show resolved Hide resolved
measures/BuildExistingModel/measure.rb Outdated Show resolved Hide resolved
resources/options_lookup.tsv Show resolved Hide resolved
test/analysis.rb
@@ -62,8 +62,7 @@ def expected_baseline_contents(testing)
'existing.osw',
'existing.xml',
'in.osm',
'in.idf',
'schedules.csv'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we remove schedules.csv because now we actually sample Occupants=0?

@afontani
Copy link
Contributor Author

afontani commented Jun 6, 2023 •
edited
Loading

Should n_buildings_represented in the project ymls be updated (since adding AK/HI)?

Because integration test samples change, how do / should we check for regressions?

Thanks. Addressed a4bce99. I have taken a look at the regression comparisons before this commit. Increasing the unit counts will just increase the total energy. Moving forward we should be consistent after the merge.

joseph-robertson
joseph-robertson approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@joseph-robertson joseph-robertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI comes back with ✔️, I'm good with this.

@afontani afontani changed the title RECS 2020 Development Effort Update to RECS 2020 data Jun 8, 2023
@afontani afontani merged commit 79c130d into develop Jun 8, 2023
@afontani afontani deleted the recs2020_develop branch June 8, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseph-robertson joseph-robertson joseph-robertson approved these changes

Assignees

@afontani afontani

Labels
None yet
Projects
None yet
Milestone
ResStock v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@afontani @joseph-robertson @rajeee @lixiliu