Don't request output for "invalid" datapoints #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
==========================================
- Coverage 93.05% 93.04% -0.01%
==========================================
Files 165 165
Lines 47897 47899 +2
==========================================
Hits 44569 44569
- Misses 3328 3330 +2
Continue to review full report at Codecov.
|
shorowit
reviewed
Jul 8, 2019
| @@ -1,2 +1,2 @@ | |||
| Option=100% Incandescent Option=60% CFL Hardwired, 34% CFL Plugin Option=60% LED Hardwired, 34% CFL Plugin Option=60% CFL Option=100% LED Option=100% LED, Low Efficacy Option=100% LED, Holiday Lights Option=20% LED | |||
| 0.125 0.125 0.125 0.125 0.125 0.125 0.125 0.125 | |||
| Option=100% Incandescent "Option=60% CFL Hardwired, 34% CFL Plugin" "Option=60% LED Hardwired, 34% CFL Plugin" Option=60% CFL Option=100% LED "Option=100% LED, Low Efficacy" "Option=100% LED, Holiday Lights" Option=20% LED Option=NA | |||
There was a problem hiding this comment.
I would call it "None" instead of "NA", similar to the Plug Loads and appliance parameters. Also, don't you have to add it to options_lookup.tsv?
shorowit
approved these changes
Jul 8, 2019
shorowit
added a commit
that referenced
this pull request
Apr 3, 2020
363f9f23c Adds/updates auto logic for several arguments. Fixes appliance locations. Adds a new extra-auto.osw that tests many auto arguments. 35dd91cda Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into build-res-hpxml 50f08783b Merge pull request #286 from NREL/HPXML_measure_defaults 240c8f64a Bugfix. 5542f9809 Fixing my typos. 3370ad410 :-/ 20e4f4adb Minor bugfixes and code cleanup. 74ee859a6 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into HPXML_measure_defaults 1bfd04aeb Code update and clean up. 49ade3c16 Clean up 13139ff22 Bugfixes. b6ba5921b Add BA climate zones e4012c95d Set water heater location based on Building America climate zone Bugfixes 9895952b9 Set standard hot water piping length to an optional input Update measure.rb, tasks.rb, and EPvalidator.rb 94706d5b0 Update tasks.rb 642b9397d Update EPvalidator.rb Move defaulting code for PV and appliances to set_default_and_globals method. Update base-misc-defaults.xml 5aca36385 Remove defaulted properties from base-misc-defaults.xml. bed12ac52 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into HPXML_measure_defaults 0528ed8ae Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into HPXML_measure_defaults dbc1f7dcc Merge branch 'HPXML_measure_defaults' of https://github.com/NREL/OpenStudio-HPXML into HPXML_measure_defaults 49e89fa9c fix equation label positions 1726f4608 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into HPXML_measure_defaults f2e29f636 Apply rubocop. 289e09d87 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into HPXML_measure_defaults 45fd30d87 minor changes to hpxml_generation.rst 56ca00cda Merge branch 'HPXML_measure_defaults' of https://github.com/NREL/OpenStudio-HPXML into HPXML_measure_defaults 026e11345 minor changes in hpxml_generation.rst 1b851c79d picked up shorowit's comments 2e5197a36 Update resources/EPvalidator.rb 277008769 Update resources/EPvalidator.rb ad77667c2 Default efficiency values for appliances (not location or fuel type) 027a77fd6 removed a print line in measure.rb 9159d94d5 Use AverageCeilingHeight instead as backup to calculate conditioned building volume 74bf9585b Relaxed PV inverter efficiency and system loss fraction git-subtree-dir: resources/hpxml-measures git-subtree-split: 363f9f23c9b0601201b702287f82156479d7c9c3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue raised on UH: https://unmethours.com/question/39408/parametric-analysis-tool-downselect-logic-location-options/