Fix bug when you specify all br but not ba #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
=======================================
Coverage 93.13% 93.13%
=======================================
Files 168 168
Lines 48821 48821
=======================================
Hits 45469 45469
Misses 3352 3352
Continue to review full report at Codecov.
|
joseph-robertson
added a commit
that referenced
this pull request
Mar 19, 2020
56fa14b76 Add argument for simulation timestep. d48fe765c Merge branch 'master' into build-res-hpxml c904bba0e Merge pull request #320 from NREL/attics_foundations f9f3887de Merge pull request #319 from NREL/ci_hvac_sizing 7321a8f5d Ensure unique IDs. 65e05153c Adds attic/foundation elements to HPXML files for all missing types, for consistency. d62bfd3c3 Fixes missing HVAC sizing results on CI. 025fa0700 Remove files. 6fa8858a4 Fix alphabetical order. [ci skip] a0a5bf643 Fixes attics in a couple HPXML files. 5d2aecd66 Merge pull request #295 from NREL/301-2019b 8f657b89c Merge pull request #318 from NREL/rubocop_via_cli f320ab82c Runs rubocop command using rubcop gem inside OS CLI. No longer need ruby environment and local rubocop gem installed. d8b2e3faf Bugfix. d493871e2 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into 301-2019b 25585a471 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into build-res-hpxml 709dbf947 Merge pull request #317 from NREL/wood e2b13d9da Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into wood 5aae8c2f9 Merge pull request #316 from NREL/surface_methods 75c5ebc0f Minor cleanup. a62406993 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into surface_methods c5c532672 Additional methods. f7d7d24aa Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into build-res-hpxml 392eefc33 Merge pull request #315 from NREL/rubocops 05183ab77 Update tests. 6c2b22322 Adds wood and wood pellets to reporting measure. We were already allowing them to be modeled. 26f02b55a Adds is_exterior_thermal_boundary method and some cleanup. 2bf370b99 Adds is_exterior, is_interior, is_thermal_boundary HPXML methods. a2cb73969 Missed one. 5b0fcf15e Adds several Style cops. f18076b36 Enable a couple Lint autocorrect cops. ec917556d Merge branch 'build-res-hpxml' of https://github.com/NREL/OpenStudio-HPXML into build-res-hpxml 9b8020e1b Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into build-res-hpxml d035afbc3 Merge pull request #314 from NREL/hpxml_class2 03f41ed55 Small improvements to solar thermal documentation. [ci skip] f09a7bfa3 Small updates. 89dcdf5e4 Adds constants. 82e519847 Adds some more helper methods. f8cd17418 Add first pass on helper methods (e.g., wall.windows, window.wall). Update class to better mirror HPXML schema. 861360a50 Remove Attic from a couple files. [ci skip] 83e3d842f Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into 301-2019b 2fadcc0af Within Infiltration Volume only required for unvented attics/foundations. eff509aca Add WithinInfiltrationVolume for attics and foundations. 554225e0a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into 301-2019b 05ba5bfd6 Allows Standard 301-2019 as the basis for calculations. Work in progress. git-subtree-dir: resources/hpxml-measures git-subtree-split: 56fa14b7658c79afb76e58e88a4739d28aba924b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.