Remove invalid characters from option names #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorowit
approved these changes
Aug 20, 2019
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
- Coverage 93.13% 93.13% -0.01%
==========================================
Files 168 168
Lines 48822 48822
==========================================
- Hits 45470 45469 -1
- Misses 3352 3353 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes options that would fail the validation proposed in NREL/buildstockbatch#99
This does not actually make changes to the validation to catch incidents of this happening in the future.
Several option names had characters in the title that are reserved for
ApplyUpgradelogic by BuildStockBatch. This removes those characters from options_lookup.