Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more efficient options for dw, cw, cd #329

Merged
merged 11 commits into from
Oct 17, 2019
Merged

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Oct 15, 2019

Pull Request Description

We need "more efficient" options for idsm-scout and mf aedg. Currently, the dw, cw options are causing increased energy consumption. Janet had started to look into this. Turns out things related to the energy guide label, like rated_annual_energy, annual_cost, and test_date, had not been updated.

Options (and tests) updated/added:

  • Dishwasher
    • 270 Rated kWh
    • 255 Rated kWh
    • 220 Rated kWh
    • 199 Rated kWh
    • 144 Rated kWh
  • Clothes Washer
    • EnergyStar More Efficient (90 kWh)
    • EnergyStar Most Efficient (60 kWh)
  • Clothes Dryer
    • Electric, Premium, EnergyStar
    • Electric, Heat Pump, Ventless
    • Electric, Premium, Heat Pump, Ventless

Checklist

Not all may apply:

  • Unit tests have been added or updated
  • The update_measures rake task has been run
  • The test:regenerate_osms rake task has been run
  • Unit tests and integrity checks all pass locally
  • PAT project measures/outputs have been updated
  • Documentation has been modified appropriately
  • Any new options are added to project_testing
  • project_testing runs without any failures
  • No unexpected circleci regression test changes
  • All tests are passing (green) on circleci
  • This branch is up-to-date with master

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

@joseph-robertson joseph-robertson self-assigned this Oct 15, 2019
@codecov-io
Copy link

codecov-io commented Oct 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@e3c0faf). Click here to learn what that means.
The diff coverage is 88.99%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #329   +/-   ##
=========================================
  Coverage          ?   92.62%           
=========================================
  Files             ?      167           
  Lines             ?    48919           
  Branches          ?        0           
=========================================
  Hits              ?    45310           
  Misses            ?     3609           
  Partials          ?        0
Impacted Files Coverage Δ
...measures/HPXMLtoOpenStudio/resources/appliances.rb 88.9% <0%> (ø)
...othesWasher/tests/ResidentialClothesWasher_Test.rb 100% <100%> (ø)
...ClothesDryer/tests/ResidentialClothesDryer_Test.rb 100% <100%> (ø)
...measures/ResidentialApplianceDishwasher/measure.rb 98.52% <100%> (ø)
...anceDishwasher/tests/ResidentialDishwasher_Test.rb 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3c0faf...3f8e9d3. Read the comment docs.

Copy link
Member

@JLReyna JLReyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new clothes washer and dishwasher options look good overall.

Are we still planning on adding a T20 clothes washer? Or was this not necessary since we're not doing a reference case?

@ejhw
Copy link
Contributor

ejhw commented Oct 17, 2019

Are we still planning on adding a T20 clothes washer? Or was this not necessary since we're not doing a reference case?

@JLReyna This is for National, not a California project, so we figured we didn't need the T24 option. We could include for completeness and to standardize options_lookup, if you think that would be useful.

@JLReyna
Copy link
Member

JLReyna commented Oct 17, 2019

Are we still planning on adding a T20 clothes washer? Or was this not necessary since we're not doing a reference case?

@JLReyna This is for National, not a California project, so we figured we didn't need the T24 option. We could include for completeness and to standardize options_lookup, if you think that would be useful.

Ah, right. I forgot because I was looking into this for IDSM (and we'll probably pull Joe's options over). I think we need the T20 for IDSM, but that wouldn't be addressed here.

@JLReyna JLReyna self-requested a review October 17, 2019 21:50
@joseph-robertson joseph-robertson merged commit d6ffb22 into master Oct 17, 2019
@joseph-robertson joseph-robertson deleted the options-updates branch October 17, 2019 23:04
Clothes Washer "EnergyStar More Efficient, 120% Usage" ResidentialApplianceClothesWasher imef=2.92 rated_annual_energy=90.0 annual_cost=8.0 test_date=2013 drum_volume=4.5 cold_cycle=false thermostatic_control=true internal_heater=false fill_sensor=false mult_e=1.2 mult_hw=1.2 location=auto plant_loop=auto
Clothes Washer "EnergyStar Most Efficient, 80% Usage" ResidentialApplianceClothesWasher imef=2.92 rated_annual_energy=60.0 annual_cost=6.0 test_date=2013 drum_volume=4.3 cold_cycle=false thermostatic_control=true internal_heater=false fill_sensor=false mult_e=0.8 mult_hw=0.8 location=auto plant_loop=auto
Clothes Washer "EnergyStar Most Efficient, 100% Usage" ResidentialApplianceClothesWasher imef=2.92 rated_annual_energy=60.0 annual_cost=6.0 test_date=2013 drum_volume=4.3 cold_cycle=false thermostatic_control=true internal_heater=false fill_sensor=false mult_e=1.0 mult_hw=1.0 location=auto plant_loop=auto
Clothes Washer "EnergyStar Most Efficient, 120% Usage" ResidentialApplianceClothesWasher imef=2.92 rated_annual_energy=60.0 annual_cost=6.0 test_date=2013 drum_volume=4.3 cold_cycle=false thermostatic_control=true internal_heater=false fill_sensor=false mult_e=1.2 mult_hw=1.2 location=auto plant_loop=auto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it could be confusing that the "Most" and "More" options have the same IMEF. The only difference appears to be the drum volume, which would imply that the difference is not really an efficiency difference. I'd propose removing the EnergyStar More Efficient option unless there's a good reason to keep it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only two values that make a difference in the clothes washer calculation are rated_annual_energy and annual_cost. These values are different so "most" is a better option. imef and drum_volume are only used for the clothes dryer portion. imef for the "most" option could be increased slightly to reflect the lower rated_annual_energy use, but it will impact only the dryer performance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JLReyna Thanks for the explanation. A slightly reduced imef that is in roughly line with real products would be nice. We could consider including the rated kWh/yr in the option name to give it more prominence...

@joseph-robertson joseph-robertson added this to the ResStock v2.1.0 milestone Jan 30, 2020
shorowit added a commit that referenced this pull request Apr 10, 2020
9a1181576 Adds usage multiplier arguments. Cleans up cooking range/oven arguments.
44d64eece Merge branch 'usage_multipliers' of https://github.com/NREL/OpenStudio-HPXML into build-res-hpxml
6eed3d8de New sample file.
9d24dfd80 Adds optional UsageMultiplier inputs for appliances, plug loads, lighting, and water fixtures. Affects energy and/or hot water usage as appropriate.
7122510e0 Merge pull request #329 from NREL/skip-tiny-surface
f235ef474 Sync.
e588ba016 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into skip-tiny-surface
20df76922 Merge pull request #344 from NREL/fix_duct_imbalance_induced_infiltration
a01fb5eb2 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into fix_duct_imbalance_induced_infiltration
a852feb97 Assigns infiltration induced by duct leakage imbalance to the duct component load.
7824d91f3 Fixes handling of infiltration induced by duct imbalance.
5c25d69ed changes as suggested
91b8936fd Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into skip-tiny-surface
937118f93 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into skip-tiny-surface
7d1b91c58 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into skip-tiny-surface
b1b6b97d9 cleanup
f4af9c7f5 add test files
c49a6534d Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into skip-tiny-surface
12d785240 Tests added
61c840c8c skip creating small surfaces

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 9a118157648a948d6b5a511ba030cb2368896072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants