Fix assignment of bedrooms to units #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-robertson
added a commit
that referenced
this pull request
Mar 26, 2020
0a562998c5 Update test osw files. cd0aced18a Remove a test comparison exclusion. c7655c2936 Update some test osw files. 4ea1b02cd0 Start to make some arguments optional. 75930cdec7 Regenerate test osw files. 94ec655b90 Expose water heater setpoint temp and hp backup switchover temp. b249fb040a Run update_measures. 496b4a1435 Update build measure and test osws. a5400892bd Merge branch 'master' into build-res-hpxml f8c20fee25 Merge pull request #331 from NREL/model-reset 12a184406c Update warning message. [ci skip] 140aff3932 Remove any existing objects from the model. 72b4b997d4 Merge pull request #328 from NREL/init_defaults f67b996964 Various code cleanup. a3452ed71a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into init_defaults 7dc076a7b6 Merge pull request #330 from NREL/build-res-hpxml-compare-xml 66155c08a7 Removes compare-xml gem, replaced with simple string comparisons. 5480f9b83d Update translator measure to remove existing model objects. 9e4058fb7a Bugfix for HEScore. 545d47d50b Update tests. 5d02ea72ee Include more defaults. ff69e52994 First pass on setting HPXML defaults up front. Updates measure arguments to support additional output products. Adds support for writing the HPXML file (after defaults applied). 8e44fbbcbb Merge pull request #321 from NREL/operable_windows 190b7d15b3 Update number of residents. 6778aae5b6 More updates to test files. 5822021f78 Update some test file default values. 6573376398 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into operable_windows c7741eb61f Fix test. 4bb3370e38 Bugfix. 448af9fe28 Bugfixes. 1a16300329 Clean up some test files. e163da8cc2 Fix tests. 03c31596fb Further reduce test files. Adds a single base-misc-defaults.xml to cover most defaults. 4922a04314 Reduce number of test files. 2b010da0f4 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into operable_windows 4b92755558 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into operable_windows f5f53a169f Minor improvements to get_default_azimuths. 89b64fe2db Bugfix. dd3eb1fe08 Moves calculation to HPXML class. a56732fb2b Switches from BuildingConstruction/extension/FractionofOperableWindowArea to Window/Operable while preserving the minimum number of unique windows modeled in EnergyPlus for reasons of speed. git-subtree-dir: resources/hpxml-measures git-subtree-split: 0a562998c5a1d9bd857387485e352a2f24ab09f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This fixes a bug when you try to assign, e.g.,
3, 2, 1, 2, 2, 3numbers of bedrooms to 6 building units.Checklist
Not all may apply:
update_measuresrake task has been runtest:regenerate_osmsrake task has been runproject_testingproject_testingruns without any failuresFor more information on how to perform these checklist items, see the documentation's Advanced Tutorial.