Remove "auto" option for number of occupants #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the reasoning behind this? |
|
I'll let @ejhw take that question. |
|
@shorowit We added a TSV for number of occupants. Joe suggested that we remove the |
|
It seems like there's no harm in continuing to allow someone to use it, but if you really want to remove it, I don't understand why this code isn't cleaned up more. For example, the argument should be changed from a string to a double and then you should remove all of the |
|
Thanks @shorowit. |
|
Let's remove Occupants=auto from the options lookup, but leave the ability to have num_occupants=auto in the measures. Sound ok? |
joseph-robertson
added a commit
that referenced
this pull request
Apr 24, 2020
…9ce73 8c8c659ce73 Handle more auto args and regenerate osws. e5eec12dcfc Merge branch 'master' into build-res-hpxml 4edf532409e Merge pull request #364 from NREL/partition_wall_bugfix 70387966cf5 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into partition_wall_bugfix 402ff3cb2e0 Merge pull request #357 from NREL/HPXML_measure_defaults cfadd32ca41 Remove one line that does nothing. 8fe1418c0c9 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into HPXML_measure_defaults a5d3738b349 Relax tolerance. f0a301755a1 Merge pull request #363 from NREL/epw-file-path d80ae7a8601 Minor fix for interior partition walls. They should have drywall layers on both sides. e259a9a9d58 Changes extension/EPWFileName to extension/EPWFilePath to allow absolute paths to be provided as an alternative to just the file name. f8a7afd4f51 A few more minor docs updates. [ci skip] c46d23a06b2 Code update. 89f3eb3b383 Docs clarification. [ci skip] f9bcd7e1913 Bugfix and cleanup. d6f340091d3 Remove more unused test osws. 91abdfbb975 Merge pull request #360 from NREL/natural_ventilation 666225911ff Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into natural_ventilation 1e2b5bf6e18 Bugfix. f698739aab2 Re-enable all tests. c33721792ab Merge pull request #362 from NREL/allow_small_tolerance_for_hvac_fractions_take2 77119cf71cc Remove solar evac tube test osw. 2851b809d6b Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into natural_ventilation 6f721b334c7 Simpler bugfix. 02e0ebf3c18 Add RE test when using UEF. Minor code simplification. 0831c08b8e5 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into HPXML_measure_defaults 20181415995 Fix test. f80e3ecf838 Add test osw for indirect solar frac. ff4c4f7ee57 Merge branch 'master' into build-res-hpxml 13a99cc4ceb Code update. 75848aed528 Prevent E+ from potentially modeling identical windows (that only differ based on FractionOperable). 3ae65880883 Merge branch 'HPXML_measure_defaults' of https://github.com/NREL/OpenStudio-HPXML into HPXML_measure_defaults 1c9f65ba3ec Add default recovery efficiency for storage water heaters Change some method names ddd36e0a7ac Merge pull request #354 from NREL/solar_fraction 9cdad02204f Adds more documentation for default values. e97b5fe6206 Tweak natural ventilation algorithm based on operable window input. fd3c538ceba Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into solar_fraction 395614e0419 Various documentation improvements (related to this branch and other stuff). 4286cb61ffa Add base-misc-defaults2.xml fbd8b76e780 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into HPXML_measure_defaults 33003c3010f Code update. e1014061105 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into HPXML_measure_defaults f50858ffeba Add HPXML defaults including: - Hot water recirculation pump power - Hot water recirculation loop length - Hot water recirculation branch length - Solar thermal storage volume - Storage water heater capacity - Storage water heater tank volume c32c3379a04 Bugfix for solar thermal hot water load reported. 0f7027787c6 Update invalid solar thermal test files to use the detailed solar inputs. f1e723263b9 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into solar_fraction a4debab7498 Minor docs update. b89a9bf6dc5 ConnectedTo is now optional when SolarThermalSystem/SolarFraction is used. When not provided, it applies to all water heaters. Also allows solar fraction to apply to combi systems. Removed a few solar test files. git-subtree-dir: resources/hpxml-measures git-subtree-split: 8c8c659ce734be2b8c1ac9ef6069b42b28ece6a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #[issue number here].
Pull Request Description
[description here]
Checklist
Not all may apply:
PAT project measures/outputs have been updatedDocumentation has been modified appropriatelyAny new options are added toproject_testingproject_testingruns without any failuresFor more information on how to perform these checklist items, see the documentation's Advanced Tutorial.