Addresses #386, fix misc pool tsv files and updates project_singlefamilydetached masonry walls #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-robertson
changed the title
ejhw
approved these changes
Feb 5, 2020
| 0.004000 0.014000 0.982000 | ||
| Dependency=Misc Pool Option=Electric Option=Gas Option=None | ||
| None 0.000000 0.000000 1.000000 | ||
| Has Pool 0.053333 0.186667 0.760000 |
There was a problem hiding this comment.
I took these from the values for National Average in the options lookup.
- 7.5% of houses have pools (pool_pump_mult=0.075)
- 1.8% of houses have pool heaters (pool_heater_elec_mult=0.004 + pool_heater_gas_mult=0.014)
So 1.8/7.5=24% of homes with pools have pool heaters, and 100-24=76% of homes with pools do not have pool heaters.
| Misc Pool Pump 1.0 HP Pump ResidentialMiscLargeUncommonLoads has_pool_pump=true pool_pump_annual_energy=2250 pool_pump_mult=1.0 | ||
| Misc Pool Pump 0.75 HP Pump ResidentialMiscLargeUncommonLoads has_pool_pump=true pool_pump_annual_energy=2250 pool_pump_mult=0.75 | ||
| Misc Pool Schedule None ResidentialMiscLargeUncommonLoads "pool_weekday_sch=0.003, 0.003, 0.003, 0.004, 0.008, 0.015, 0.026, 0.044, 0.084, 0.121, 0.127, 0.121, 0.120, 0.090, 0.075, 0.061, 0.037, 0.023, 0.013, 0.008, 0.004, 0.003, 0.003, 0.003" "pool_weekend_sch=0.003, 0.003, 0.003, 0.004, 0.008, 0.015, 0.026, 0.044, 0.084, 0.121, 0.127, 0.121, 0.120, 0.090, 0.075, 0.061, 0.037, 0.023, 0.013, 0.008, 0.004, 0.003, 0.003, 0.003" "pool_monthly_sch=1.154, 1.161, 1.013, 1.010, 1.013, 0.888, 0.883, 0.883, 0.888, 0.978, 0.974, 1.154" | ||
| Misc Pool Schedule National Average ResidentialMiscLargeUncommonLoads "pool_weekday_sch=0.003, 0.003, 0.003, 0.004, 0.008, 0.015, 0.026, 0.044, 0.084, 0.121, 0.127, 0.121, 0.120, 0.090, 0.075, 0.061, 0.037, 0.023, 0.013, 0.008, 0.004, 0.003, 0.003, 0.003" "pool_weekend_sch=0.003, 0.003, 0.003, 0.004, 0.008, 0.015, 0.026, 0.044, 0.084, 0.121, 0.127, 0.121, 0.120, 0.090, 0.075, 0.061, 0.037, 0.023, 0.013, 0.008, 0.004, 0.003, 0.003, 0.003" "pool_monthly_sch=1.154, 1.161, 1.013, 1.010, 1.013, 0.888, 0.883, 0.883, 0.888, 0.978, 0.974, 1.154" |
There was a problem hiding this comment.
Is this schedule used for Pool Heaters too?
ejhw
reviewed
Feb 6, 2020
There was a problem hiding this comment.
@joseph-robertson Should pool heat be dependent on region too? Looks like there is some dependency there, though not a lot of samples to go by.
ejhw
approved these changes
Feb 6, 2020
|
I'm good with this, but I'd like @JLReyna to take a quick look to be aware of the low sample sizes in some cases. We might consider having fewer regions and/or combining with RECS 2015 to get more samples. |
JLReyna
changed the title
joseph-robertson
added a commit
that referenced
this pull request
May 15, 2020
ae331e56d Add arg for site type. More arg validation. 7142f386e Merge branch 'master' into build-res-hpxml-v3 9cdcd45d6 Update README. [ci skip] b7dd41d0a Merge pull request #389 from NREL/wood_cord 6e360826c Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into wood_cord 22918d2cc Merge pull request #388 from NREL/refactor_pv_lighting 9e39b3788 Update workflow test. 629e1774f Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into refactor_pv_lighting a419edbc2 Merge pull request #387 from NREL/performance_adjustment b342f26ae Renames "Wood" to "Wood Cord" in the reporting measure outputs, so as to better distinguish from "Wood Pellets". e01bf3687 Add tests. 84a0bacda Small code refactor of PV and lighting. a6fe782ae Bugfix. 697d1f202 Small cleanup. 42f50c8ec Changes tankless performance adjustment to a multiplier. 31bb6d1d6 ERI bugfix for buildings w/ both a DFHP and an ASHP. a37e2569e Merge pull request #386 from NREL/require_speedup f0a05b12f Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into require_speedup 31a951758 Merge pull request #385 from NREL/framefloor_other_space_above_or_below a4841bca9 Revert accidental change. 405345cc5 Attempt to speed up requires. ee7e9edc9 For FrameFloors, removes the "other housing unit above" and "other housing unit below" enumerations. Instead, FrameFloors in MF/attached buildings that are adjacent to any of the "other" space types (i.e., "other housing unit", "other heated space", "other multifamily buffer space", and "other non-freezing space") must now have an ``extension/OtherSpaceAboveOrBelow`` property set to either "above" or "below". 7f804848b Merge pull request #383 from NREL/airflow_refactor 4f7998d51 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into airflow_refactor a96f0f614 Bugfix. 808e84a30 Bugfix. a0fda68d2 Merge pull request #384 from NREL/outside_appliances ff0ce92bf Small code refactor to make it easier for the methods to be called externally. 4dc685ec3 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into airflow_refactor e775eb401 Bugfix. 86c62cf25 Vary dishwasher & cooking range locations more in test files. 7ec430687 Adds unit tests. d2a23af26 Bugfix & code cleanup. Added a test file. 7f9616cfa Bugfix. f6958ab9c A little duct refactoring. b41698824 Minor cleanup. 41c376575 Bugfixes. 23c0dd3dd Refactor mechanical ventilation. 2e11f19c4 Fix merge. a95827870 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into airflow_refactor eaaad1e07 Remove NaturalVentilation class from airflow.rb. Simplify natural ventilation setpoint calculation. 8074cafe4 Remove Infiltration class from airflow.rb. ba1b440d3 Add HPXML's SiteType as an optional input. 62dd50cef Remove Building and ZoneInfo classes from airflow.rb. 78e447771 Refactor whole house fan. git-subtree-dir: resources/hpxml-measures git-subtree-split: ae331e56df8e6ccb60e3ac683bd56b8118ecc56a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #386.
Pull Request Description
[description here]
Checklist
Not all may apply:
project_testingproject_testingruns without any failuresFor more information on how to perform these checklist items, see the documentation's Advanced Tutorial.