Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy schedules #414

Merged
merged 9 commits into from
Mar 5, 2020
Merged

Fuzzy schedules #414

merged 9 commits into from
Mar 5, 2020

Conversation

rajeee
Copy link
Contributor

@rajeee rajeee commented Feb 26, 2020

Pull Request Description

Smears the Heating and Cooling offset schedules period +- 2hours around existing times.

Checklist

Not all may apply:

  • Unit tests have been added or updated
  • All rake tasks have been run, and pass
  • Documentation has been modified appropriately
  • Any new options are added to project_testing
  • project_testing runs without any failures
  • No unexpected regression test changes
  • All tests are passing (green) on circleci
  • The changelog has been updated appropriately
  • This branch is up-to-date with master

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

Cooling Setpoint Offset Period Day Setup -2h ResidentialHVACCoolingSetpoints "weekday_offset_schedule=0,0,0,0,0,0,0,1,1,1,1,1,1,1,1,0,0,0,0,0,0,0,0,0" "weekend_offset_schedule=0,0,0,0,0,0,0,1,1,1,1,1,1,1,1,0,0,0,0,0,0,0,0,0"
Cooling Setpoint Offset Period Night Setup ResidentialHVACCoolingSetpoints "weekday_offset_schedule=1,1,1,1,1,1,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1,1" "weekend_offset_schedule=1,1,1,1,1,1,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1,1"
Cooling Setpoint Offset Period Night Setup +1h ResidentialHVACCoolingSetpoints "weekday_offset_schedule=1,1,1,1,1,1,1,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1" "weekend_offset_schedule=1,1,1,1,1,1,1,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1"
Cooling Setpoint Offset Period Night Setup +2h ResidentialHVACCoolingSetpoints "weekday_offset_schedule=1,1,1,1,1,1,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1,1" "weekend_offset_schedule=1,1,1,1,1,1,1,1,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix weekdays

@rajeee rajeee requested a review from afontani March 3, 2020 22:05
@rajeee
Copy link
Contributor Author

rajeee commented Mar 3, 2020

@afontani I did a local test. It seems to be shifting schedules as expected.

Copy link
Contributor

@afontani afontani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajeee The update with master caused some issues, but I think I have them straightened out.

@afontani afontani merged commit b9cac6b into master Mar 5, 2020
@afontani afontani deleted the fuzzy_schedules branch March 5, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants