Roofing material options and tsvs updates #485
Conversation
|
A couple questions:
|
|
These commits look fine. However, like @trynthink said, some extra changes were implemented in the Grid Benefit Analysis branch that arent implemented here: |
@TobiAdekanye So I'm a little confused. Are you implying we should be carrying thru changes related to Heating/Cooling Setpoint Apply Offset? And weather? And vacancy? From @trynthink I got the impression we only wanted changes related to roof material. @joseph-robertson. There were some file changes that I thought didn't apply to weather or vacancy but I might be wrong e.g. |
I don't believe these changes to possible roofing materials require any modifications to Radiant Barrier.tsv. |
|
@trynthink @TobiAdekanye Is this ready to go? |
…3c52e 8f87813c52e Refine testing for multiple heating or cooling. 94159e65dfd Leave out pv system false. fd77d1546a8 Merge branch 'master' into build-res-hpxml-v3 1ed004a8fe1 Merge pull request #490 from NREL/fix_ci_tests ad65c79ed03 Some tests weren't running on the CI. 1c5c8f58365 Merge pull request #488 from NREL/shared-pv-system ff1166ecfdd Change IsSharedSystem to be optional for PV, default to false. No longer a breaking change. cff0b12b8f2 Merge pull request #487 from NREL/unconditioned-surface-adjacent-to-other-housing-unit 5f32ac58043 Small cleanup. 53218ca1bcf Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into unconditioned-surface-adjacent-to-other-housing-unit d96ecaff135 Require materials and psychros in case we need to weather cache. 30936180fef Merge pull request #485 from NREL/hvac-sizing-controls 359b2354edb Small docs update. [ci skip] b8c31283a24 Bugfix for a surface between an unconditioned space and "other housing unit" being incorrectly set as adiabatic. Now uses SurfacePropertyOtherSideCoefficients to appropriately set the adjacent temperature. 8379cf1b2f0 update_measures 0a6fecde90b Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac-sizing-controls 693f2063426 Merge pull request #486 from NREL/duct-lto-testing-exemption ccfd83d316f Renames DuctLeakageToOutsideTestingExemption to DuctLeakageToOutsideTestingExemption, to clarify that it is different from the total duct leakage testing exemption in ANSI/RESNET/ACCA 310. 6e298b9ca82 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hvac-sizing-controls 345ec0d6ff3 Update test. 9ba85000862 Merge pull request #484 from NREL/test_validation_cli 66fb7a83979 Bugfix. 681cb17138d Adds high-level HVAC sizing controls. 183d993cbbb Allow running test_validation.rb via the OS CLI (only ruby tests will run). The CI will continue to run all tests (i.e., including schematron-nokogiri). git-subtree-dir: resources/hpxml-measures git-subtree-split: 8f87813c52ee35e754cbac304f61f2c80b878e3d
|
@joseph-robertson It looks good to me, though it would be good to get concurrence from @TobiAdekanye as well. Is it standard practice on this repo to merge in changes on branches as-is or to merge/rebase on master and/or squash commits before merging? I'll leave it to you to clean up or revise these commits as needed (if at all) to be consistent with expectations or standard practice on this repo. |
So far on this repo we've just merged in changes on branches as-is. @TobiAdekanye does this PR look ready to go? |
|
@trynthink What is the data source for the updated roof material options? RECS? Were there any assumptions made? |
Addresses #[issue number here].
Pull Request Description
Expand roof material options and update related tsv files.
TODO:
Checklist
Not all may apply:
project_testingproject_testingruns without any failuresFor more information on how to perform these checklist items, see the documentation's Advanced Tutorial.