Account for collapsed units when determining geometry variables for infiltration calculation #518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes how geometry variables (building ffa, building volume, and building exterior wall area) are calculated in the
Airflow.rb
measure whenminimal_collapsed == True
. The "collapsed" units were not originally accounted for when determining these variables, influencing the calculated leakage area at each unit. This changes the infiltration and HVAC sizing in SFA buildings, and most likely MF buildings as well.Checklist
Not all may apply:
project_testing
project_testing
runs without any failuresFor more information on how to perform these checklist items, see the documentation's Advanced Tutorial.