Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for collapsed units when determining geometry variables for infiltration calculation #518

Merged
merged 9 commits into from
Dec 10, 2020

Conversation

aspeake
Copy link
Contributor

@aspeake aspeake commented Dec 9, 2020

Pull Request Description

Fixes how geometry variables (building ffa, building volume, and building exterior wall area) are calculated in the Airflow.rb measure when minimal_collapsed == True. The "collapsed" units were not originally accounted for when determining these variables, influencing the calculated leakage area at each unit. This changes the infiltration and HVAC sizing in SFA buildings, and most likely MF buildings as well.

Checklist

Not all may apply:

  • Unit tests have been added or updated
  • All rake tasks have been run, and pass
  • Documentation has been modified appropriately
  • Any new options are added to project_testing
  • project_testing runs without any failures
  • No unexpected regression test changes
  • All tests are passing (green) on circleci
  • The changelog has been updated appropriately
  • This branch is up-to-date with master

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

@aspeake aspeake added the bug label Dec 9, 2020
@aspeake aspeake merged commit 76ba545 into develop Dec 10, 2020
@aspeake aspeake deleted the bugfix/sfa_infiltration branch December 11, 2020 00:25
@joseph-robertson joseph-robertson added this to the ResStock v2.4.0 milestone Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants