Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure vacant units have zero ceiling fan energy #527

Merged
merged 4 commits into from
Jan 7, 2021

Conversation

afontani
Copy link
Contributor

@afontani afontani commented Jan 7, 2021

Pull Request Description

Vacant units currently have ceiling fan energy. This PR introduces an option where the ceiling fan energy is zero. The ratio of ceiling fans is kept the same, so 72% of units have ceiling fans for either occupied or vacant units. This ensures the counts of ceiling fans are consistent, but vacant units have no ceiling fan energy.

I have verified with a small run of vacant units in buildstockbatch that there is no ceiling fan energy.

Checklist

Not all may apply:

  • Unit tests have been added or updated
  • All rake tasks have been run, and pass
  • Documentation has been modified appropriately
  • Any new options are added to project_testing
  • project_testing runs without any failures
  • No unexpected regression test changes
  • All tests are passing
  • The changelog has been updated appropriately
  • This branch is up-to-date with develop

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

@afontani afontani merged commit 629ed24 into develop Jan 7, 2021
@afontani afontani deleted the fix/vacant_ceiling_fan branch January 7, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants