Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vacant Unit Heating Setpoints #541

Merged
merged 8 commits into from
Feb 15, 2021
Merged

Conversation

afontani
Copy link
Contributor

@afontani afontani commented Jan 29, 2021

Pull Request Description

Companion PR: resstock-estimation #96

Assign Vacant Unit Heating Setpoints to 55F. The assumption is close to a "don't freeze the pipes" instead of using occupied setpoints.

Checklist

Not all may apply:

  • Unit tests have been added or updated
  • All rake tasks have been run, and pass
  • Documentation has been modified appropriately
  • Any new options are added to project_testing
  • project_testing runs without any failures
  • No unexpected regression test changes
  • All tests are passing
  • The changelog has been updated appropriately
  • This branch is up-to-date with develop

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

@afontani afontani marked this pull request as ready for review February 12, 2021 20:02
Copy link
Contributor

@ejhw ejhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afontani Was the "7,001 additions, 7,000 deletions" to options_lookup.tsv a mistake?

@afontani
Copy link
Contributor Author

@ejhw: Not sure what happened with options_lookup.tsv, probably white space. To be more explicit, I reverted the changes (64e3eff) and added a single line for the new Heating Setpoint Option (d26fb15). The PR now shows only a single line changed in options_lookup.tsv

@afontani afontani merged commit 3e5bb21 into develop Feb 15, 2021
@afontani afontani deleted the feature/vacant_heating_setpoints branch February 15, 2021 16:19
@afontani afontani added this to the ResStock v2.5.0 milestone Feb 15, 2021
@afontani afontani self-assigned this Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants