Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
A bug in the buildstock.rb
get_measure_args_from_option_names()
method was causing the entirety of every TSV to be processed even when the option(s) of interest had already been found. As the number and length of TSVs has grown, so has this bottleneck.The bug causes both the BuildExistingModel and ApplyUpgrade measures to be far slower than they should be.
Time spent inside the method when running the first building w/ an upgrade from test_measures_osw.rb:
develop
branch: 62.7 seconds => 6.7 secondsrestructure-v3
branch: 38.5 seconds => 3.4 secondsChecklist
Not all may apply:
project_testing
project_testing
runs without any failuresFor more information on how to perform these checklist items, see the documentation's Advanced Tutorial.