Bug Fix: Too many bedrooms for small units #553
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Companion PR: resstock-estimation (#104)
This pull request updates the number of bedrooms for small units.
Problem
For small buildings "0-499", there is a possibility for the unit to have up to 5 bedrooms. The large number of bedrooms do not satisfy the following constraint in the geometry measures:
As a result, HPXML is throwing an error.
Solution
After taking a look at the
ffa
values for the different model types inoptions_lookup.tsv
, the smallest dwelling units have some bedroom constraints:Bedroom limits based on current ffa in options_lookup.tsv
Implemented Assumption: Dwelling units that are 0-499 ft2 will have a maximum of 2 bedrooms.
According to the constraint and the
ffa
values inoptions_lookup.tsv
, multi-family units can have 3 bedrooms. However, these dwelling units are close to the constraint above. As a result, a more uniform assumption is applied to the building stock.Checklist
Not all may apply:
project_testing
project_testing
runs without any failuresFor more information on how to perform these checklist items, see the documentation's Advanced Tutorial.