Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce running sampling probability script, try 2 #584

Merged
merged 10 commits into from
May 17, 2021

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Apr 30, 2021

Pull Request Description

Companion PR: https://github.com/NREL/resstock-estimation/pull/127.

Add in a column called the sampling_probability to each housing characteristic. The sampling_probability is the probability that a given row in the housing characteristic TSV file is sampled. This value is calculated from the product of the marginal probability of each of the dependency values being sampled for that specific row. For each housing characteristic, the sampling_probability column should sum to 1.0 and have non-negative values.

This particular column is produced via a pytest (utils/test/test_sampling_probability.py) in the resstock-estimation repository. The code that calculates the column is pulled in from a feature of the EULP-uncertainty-quantification repo.

Checklist

Not all may apply:

  • Unit tests have been added or updated
  • All rake tasks have been run, and pass
  • Documentation has been modified appropriately
  • Any new options are added to project_testing
  • project_testing runs without any failures
  • No unexpected regression test changes
  • All tests are passing
  • The changelog has been updated appropriately
  • This branch is up-to-date with develop

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

@joseph-robertson joseph-robertson added this to the ResStock v2.5.0 milestone Apr 30, 2021
@joseph-robertson joseph-robertson self-assigned this Apr 30, 2021
Base automatically changed from tsvs-from-res-est to develop May 10, 2021 16:25
@afontani afontani merged commit 8b1c9d6 into develop May 17, 2021
@afontani afontani deleted the children-updates-2 branch May 17, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants