-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace room-ac performance curves by Cutler curves #586
Conversation
This is the first item from https://trello.com/c/0lwzEytE/76-port-os-hpxml-fixes-over-to-develop. So for example do we want to go ahead and merge this? Or do we first want to compare each of these items to resstock-hpxml? |
@joseph-robertson I don't see any benefit to comparing to resstock-hpxml before we merge. Probably want to do a separate EULP run for this change. cc @afontani |
There's a bit more to do on this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI only shows simulation results changing for samples w/ room ACs, and they change in the expected way. I also compared the performance curves and coil COP in a single ResStock IDF to an OS-HPXML IDF and they match. This looks good to me.
We should go ahead and merge this into develop, and then @afontani can do his EULP runs. |
Pull Request Description
Backports:
example_single_family_detached_TMY.osw
with ResidentialHVACRoomAirConditioner:develop
:room-ac-curves
:Checklist
Not all may apply:
project_testing
project_testing
runs without any failuresFor more information on how to perform these checklist items, see the documentation's Advanced Tutorial.