Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace room-ac performance curves by Cutler curves #586

Merged
merged 12 commits into from
Jul 1, 2021

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented May 3, 2021

Pull Request Description

Backports:

example_single_family_detached_TMY.osw with ResidentialHVACRoomAirConditioner:

  • develop:
    image
  • room-ac-curves:
    image

Checklist

Not all may apply:

  • Unit tests have been added or updated
  • All rake tasks have been run, and pass
  • Documentation has been modified appropriately
  • Any new options are added to project_testing
  • project_testing runs without any failures
  • No unexpected regression test changes
  • All tests are passing
  • The changelog has been updated appropriately
  • This branch is up-to-date with develop

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

@joseph-robertson joseph-robertson added this to the ResStock v2.5.0 milestone May 3, 2021
@joseph-robertson joseph-robertson self-assigned this May 3, 2021
@joseph-robertson
Copy link
Contributor Author

@ejhw @afontani @aspeake

This is the first item from https://trello.com/c/0lwzEytE/76-port-os-hpxml-fixes-over-to-develop. So for example do we want to go ahead and merge this? Or do we first want to compare each of these items to resstock-hpxml?

@ejhw
Copy link
Contributor

ejhw commented May 3, 2021

@joseph-robertson I don't see any benefit to comparing to resstock-hpxml before we merge. Probably want to do a separate EULP run for this change. cc @afontani

@joseph-robertson
Copy link
Contributor Author

There's a bit more to do on this one.

Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI only shows simulation results changing for samples w/ room ACs, and they change in the expected way. I also compared the performance curves and coil COP in a single ResStock IDF to an OS-HPXML IDF and they match. This looks good to me.

@joseph-robertson
Copy link
Contributor Author

We should go ahead and merge this into develop, and then @afontani can do his EULP runs.

@joseph-robertson joseph-robertson merged commit 935faee into develop Jul 1, 2021
@joseph-robertson joseph-robertson deleted the room-ac-curves branch July 1, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants