Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number of bathrooms #601

Merged
merged 13 commits into from
Jun 10, 2021
Merged

Number of bathrooms #601

merged 13 commits into from
Jun 10, 2021

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Jun 2, 2021 •
edited
Loading

Pull Request Description

This PR makes two changes:

  1. Updates number of bathrooms to use the BAHSP equation (Nbedrooms/2 + 0.5) and fixes the values used for SFA/MF.
  2. Rounds down the number of bathrooms to the nearest integer for the assumption of number of bath fans. (E.g., a 1.5 bathroom home will now have 1 bath fan instead of 1.5 bath fans.)

Context

I was looking into why spot ventilation energy use is different between ResStock and ResStock-HPXML and found it's caused by different number of bathrooms. In looking into it, I found several things:

  1. ResStock scales #bathrooms based on floor area, while ResStock-HPXML scales based on number of bedrooms (using the BAHSP equation).
  2. ResStock is assuming 1.5 bathrooms for any size SFA/MF unit, which seems wrong and was probably inadvertent.
  3. ResStock scales bathroom fan energy based on total #bathrooms (e.g., 1.5) while ResStock-HPXML rounds down to the nearest integer for the assumed number of complete bathrooms (e.g., 1).

Checklist

Not all may apply:

  • Unit tests have been added or updated
  • All rake tasks have been run, and pass
  • Documentation has been modified appropriately
  • Any new options are added to project_testing
  • project_testing runs without any failures
  • No unexpected regression test changes
  • All tests are passing
  • The changelog has been updated appropriately
  • This branch is up-to-date with develop

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

@shorowit shorowit self-assigned this Jun 2, 2021
@shorowit shorowit marked this pull request as ready for review June 2, 2021 22:02
@shorowit
Copy link
Contributor Author

shorowit commented Jun 2, 2021

This also fixes inconsistent water heater sizes between ResStock and ResStock-HPXML.

ejhw
ejhw approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@ejhw ejhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shorowit —good catch!

@ejhw
Copy link
Contributor

ejhw commented Jun 9, 2021

@afontani for your awareness

shorowit and others added 5 commits June 10, 2021 08:03
shorowit and others added 2 commits June 10, 2021 11:11
@shorowit
Merge branch 'develop' of https://github.com/NREL/resstock into num_b…
6b0accb 
…athrooms

# Conflicts:
#	test/test_samples_osw/base_results/results.csv
Latest results.
ba2cff4
@shorowit shorowit merged commit 8d94a6f into develop Jun 10, 2021
@shorowit shorowit deleted the num_bathrooms branch June 10, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseph-robertson joseph-robertson joseph-robertson approved these changes

@ejhw ejhw ejhw approved these changes

Assignees

@shorowit shorowit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shorowit @ejhw @joseph-robertson