Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add geometry_story_bin, add story_bin as dependency to geometry_wall_… #759

Merged
merged 13 commits into from
Nov 18, 2021

Conversation

lixiliu
Copy link
Contributor

@lixiliu lixiliu commented Nov 4, 2021

Resolves:

  • #[https://github.com/NREL/resstock-estimation/issues/175]
  • #[https://github.com/NREL/resstock-estimation/issues/145] - reverting fix for high brick %s in newer vintages

ResStock-Estimation companion: https://github.com/NREL/resstock-estimation/pull/177

Pull Request Description

For Issue #145:

  • Revert fix
    For Issue Use subtree2 branch of OpenStudio-BEopt #175:
  • Create Geometry Story Bin: ['<8', '8+'] from RECS 2009
  • Add Geometry Story Bin dep in Geometry Wall Type, add "Not Applicable" as a Wall Type option
  • Modify Insulation Wall to include Not Applicable" as a Wall Type option

Checklist

Not all may apply:

  • Unit tests have been added or updated
  • All rake tasks have been run, and pass
  • Documentation has been modified appropriately
  • Any new options are added to project_testing
  • project_testing runs without any failures
  • No unexpected regression test changes
  • All tests are passing
  • The changelog has been updated appropriately
  • This branch is up-to-date with develop

For more information on how to perform these checklist items, see the documentation's Advanced Tutorial.

@lixiliu lixiliu requested review from ejhw and JLReyna November 4, 2021 06:24
@lixiliu lixiliu self-assigned this Nov 4, 2021
@lixiliu lixiliu requested a review from aspeake November 12, 2021 01:16
@aspeake aspeake merged commit 5d54f1e into develop Nov 18, 2021
@aspeake aspeake deleted the fix/wall_type_and_story_bin branch November 18, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants