Multi year resource handlers #17
Conversation
Add multi-year cli update docs
|
WAPP 10343 20.01.01 |
There was a problem hiding this comment.
Looks great overall! I think we should consider a major file reorg though. I need a flow chart to keep everything straight. For example, these files groups are very similar:
mutli_year_resource, renewable_resource, resource, resource_extraction
resource_cli, solar_cli, wind_cli
Could we rename resource to h5_resource? Just the filename i mean. Maybe change the cli suffix to a prefix? Make subfolders to the "extraction" utilities vs. the handlers?
Basically if I am super confused by all these files I'm afraid the public will have no idea how to use anything.
rex/mutli_year_resource.py
Outdated
| @@ -0,0 +1,834 @@ | |||
| # -*- coding: utf-8 -*- | |||
| """ | |||
| Classes to handle resource accross multiple files | |||
rex/mutli_year_resource.py
Outdated
| return year in self.years | ||
|
|
||
| @property | ||
| def attrs(self): |
There was a problem hiding this comment.
Can we add this to the normal Resource class? Can't tell you how many times i've wanted it instead of calling .get_attrs()
|
What if we move resource_extraction and the cli files to a sub_package since they are all related? |
|
I think that would go a long way, yes. Maybe add a readme to that subpackage too? We can add the link to the docs but it would be good to have a one sentence explanation of what are these files and why would you want to use them vs. the handlers. |
|
Okay, how does that look? Also, there was a global_attrs property, I also added attrs as a further alias |
|
I think its a lot better, what do you think? |
Multi year resource handlers
Feature Request from the guys who created the new US_Wave data (on eagle and HSDS). They want a single entry point to be able to pull multi-year profiles. Was a fund implementation, I'm particularly happy with the ability to pass "year" values in the axis 0 slice as a string or list of strings