Make hsds optional dependency #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantbuster
approved these changes
Jul 29, 2024
|
it was only HSDS as far as I can tell. If needed, we can add h5pyd to this down the line I think |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
Make hsds optional dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HSDS was causing some installation conflicts, particularly with https://github.com/NREL/cloud_fs
This PR moves HSDS to be an optional dependency, which still gives access to all HSDS functionality, but without requiring it to be installed with every rex distribution.