Fix a bug flagged by the warning: left operand of comma operator has no effect #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no effect [-Wunused-value]. * solarpilot/Heliostat.cpp (getPanelById): matrix_t's operator[] only takes a single int and returns the address of the row. Instead, use the public at() method to properly accesss a matrix element by row and column number.
|
well spotted, ben! |
nickdiorio
reviewed
Sep 20, 2017
| @@ -745,23 +745,22 @@ Reflector *Heliostat::getPanelById(int id){ | |||
|
|
|||
| for (int j=0; j<(int)ncantx; j++) { | |||
| for (int i=0; i<(int)ncanty; i++) { | |||
| if (_panels[j,i].getId() == id){ | |||
| return &_panels[j,i]; | |||
There was a problem hiding this comment.
Seems like a fairly insidious bug, from the perspective that an operator [] with two operands is not defined for a matrix_t, and so only the right operand gets evaluated according to https://stackoverflow.com/questions/54142/how-does-the-comma-operator-work .
tvdmitrii
pushed a commit
to tyneises/ssc
that referenced
this pull request
Jul 6, 2018
Fix a bug flagged by the warning: left operand of comma operator has no effect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35.
takes a single int and returns the address of the row. Instead, use
the public at() method to properly access matrix elements by row
and column number.