Gb/trh loss #142
Merged
Gb/trh loss #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or surface met variables
…eaned up surface model meta data
…e random error but less systematic error
bnb32
requested changes
Jan 19, 2023
| @@ -1106,7 +1106,7 @@ def preflight(self): | |||
| msg = (f'sample_shape[2] ({self.sample_shape[2]}) cannot be larger ' | |||
| 'than the number of time steps in the raw data ' | |||
| f'({len(self.raw_time_index)}).') | |||
| if len(self.raw_time_index) >= self.sample_shape[2]: | |||
| if len(self.raw_time_index) < self.sample_shape[2]: | |||
There was a problem hiding this comment.
good catch, fixed this in my current dev branch also.
There was a problem hiding this comment.
it was driving me insane haha
sup3r/models/surface.py
Outdated
Comment on lines
146
to
149
| meta = params['meta'] | ||
| args = signature(cls.__init__).parameters | ||
| kwargs = {k: v for k, v in meta.items() if k in args} | ||
| model = cls(**kwargs) |
There was a problem hiding this comment.
you use this code block in linear.py also, and it seems useful as a separate function or an inherited method?
There was a problem hiding this comment.
Yeah good point i think we can actually inherit the surface model from the linear model. Let me test it.
bnb32
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.