Bnb/era edits #146
Merged
Bnb/era edits #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnb32
force-pushed
the
bnb/era_edits
branch
2 times, most recently
from
db8398a
to
9f09161
Compare
bnb32
force-pushed
the
bnb/era_edits
branch
4 times, most recently
from
e7ea76c
to
242fad2
Compare
bnb32
force-pushed
the
bnb/era_edits
branch
3 times, most recently
from
abd02cd
to
c4586f1
Compare
grantbuster
requested changes
Apr 7, 2023
| Parameters | ||
| ---------- | ||
| filepath : str | ||
| Path to the file |
There was a problem hiding this comment.
.nc file only? Move this into the NC specific class?
sup3r/preprocessing/data_handling.py
Outdated
| if len(time_key) > 0: | ||
| return time_key[0] | ||
| else: | ||
| return 'time' |
There was a problem hiding this comment.
why is this a class method instead of static? Can you make a utility function for this since the same functionality is needed in post processing above? if not, move to the nc specific classes? Can you update the docstring to clarify that this is just for .nc?
sup3r/utilities/utilities.py
Outdated
| if len(data['orog'].dims) == 3: | ||
| hgt = data['orog'][(0,) + tuple(raster_index)] | ||
| else: | ||
| hgt = data['orog'][tuple(raster_index)] |
There was a problem hiding this comment.
These interp utilities are nearing the point where we should move them all into an interp utilities class. Complexity for this method alone is quite high, and the utilities.py file alone is massive
There was a problem hiding this comment.
Yeah agreed. Moved to new class.
grantbuster
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataHandlerNCforERA addition. resolved issues with pandas version update. unpinned xarray, netcdf, sphinx. Incremented version. Removed support for python 3.7. Added python 3.10.