Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gb/fix tests #16

Merged
merged 52 commits into from
Feb 14, 2022
Merged

Gb/fix tests #16

merged 52 commits into from
Feb 14, 2022

Conversation

grantbuster
Copy link
Member

No description provided.

bnb32 and others added 30 commits February 3, 2022 12:10
@bnb32
added normalization to SpatialBatchHandler
82c61c4
@bnb32
added MultiDataHandler to handle multiple DataHandler instances. This…
d40e4af 
… is now instantiated in SpatialBatchHandler.make(). Added indexing routine to treat time dimension as stacked for the purposes of getting batches. Added raster index caching and __len__/shape properties.
@bnb32
cleaning up some linting
3ae0baa
@bnb32
adding raster_file argument to SpatialBatchHandler.make()
87e6f0a
@bnb32
raster files can be different for different targets. changed to accou…
10263ce 
…nt for this
@bnb32
all requested changes except for the batching across separate data ha…
9f7fe25 
…ndlers.
@bnb32
added method that i think will speed up batching across data handlers.
064da8e
@bnb32
big refactor of how to batch with multiple data handlers. think I upd…
181cad1 
…ated all doc strings ;)
@bnb32
added test for validation data and attribute for val_data in SpatialB…
6aac4af 
…atchHandler
@grantbuster
moved model test to load config test
135ad69
@grantbuster
modified tests a little
3a28488
@grantbuster
added 2x spatial gan and basic test to make sure the data->model link…
56795e8 
…age works and the model trains
@grantbuster
added basic save load functionality
8a4d72f
@grantbuster
added in validation to spatialgan training
b97fefe
@grantbuster
started making adaptive training procedure
cbc8c23
@grantbuster
refactored the adaptive training scheme for spatialgan model
f8725ce
@grantbuster
added better save load features for spatial gan
e225aac
@grantbuster
added model checkpoint saving
03ae9ba
@grantbuster
logging improvements
c2497a7
@grantbuster
broke up the validation to reduce GPU memory requirement
a019011
@grantbuster
added means stdevs to model attributes
f64599a
@grantbuster
incremented phygnn requirement for sup3r features
d8d419c
@grantbuster
added n=1 batching of validation data to avoid oom errors
e214965
@grantbuster
added early stop clause
28994a4
@grantbuster
fixed bug where disc predictions were not tensor
c381986
@grantbuster
added kwargs to validation loss calc
cd390a4
@grantbuster
modified confusing epoch and batch indexing in log messages
26aa65e
@bnb32 @grantbuster
added spatial sampling to DataHandler and updated others classes to p…
26c23b5 
…ass spatial_sample_shape and n_spatial_slices. Also changed n_batches to n_temporal_slices
@bnb32 @grantbuster
linter yelled
9edf053
@bnb32 @grantbuster
added downsampling time dimension with time_step input
56ad46d
bnb32 and others added 21 commits February 11, 2022 11:18
@bnb32 @grantbuster
forgot test update
22770e6
@bnb32 @grantbuster
changed time downsampling a little
0cc1769
@bnb32 @grantbuster
refined normalization
b3ea548
@bnb32 @grantbuster
slice cant take 4 args. changed time downsampling to use ::time_step …
2fc9b37 
…instead
@bnb32 @grantbuster
fixed sampling issue in utilities and problem with tests due to tempo…
19f632d 
…ral downsampling
@bnb32 @grantbuster
big refactor. removed MultiDataHandler. Added get_observation() to Da…
689de7c 
…taHandler which get a data chunk from randomly selected spatial sample and time index. SpatialBatchHandler iterates over these random batches until it hits n_batches, a user specified input. Will have to determine reasonable epoch length for this. Hopefully didnt miss doc string updates. Updated tests run.
@bnb32 @grantbuster
Added ValidationData iterator class so we could do for batch in batch…
b002b68 
…_handler.val_data. This class takes the validation indices (spatial_slices) and creates a dict of all validation indices across all handlers, with handler indices. The iterator builds arrays with n_observations = batch_size as it goes through all validation indices.
@bnb32 @grantbuster
fixed order of ops in unnormalize and cleaned up hidden properties
864d753
@grantbuster
a few mods and fixed test train spatial test
8a70320
@grantbuster
fixed epoch loss as the mean of the batch losses for that epoch, not …
9fedbce 
…the last batch (dumb)
@grantbuster
changed wtk resource extraction to extract flattened raster gid array
e69a209
@grantbuster
fixed datahandler logging, not sure how it got removed
5ca5cc3
@grantbuster
make sure batch is float32
6ebc056
@grantbuster
added more simple config tests
390a40d
@grantbuster
fixed bug where disc was always training because of total epoch loss …
beebd5c 
…> 0.45 not most recent mean batch loss
@grantbuster
allow for either raster targets+shapes OR raster file to be input
8e5fdfc
@grantbuster
edits to only train the disc model when the epoch-running-avg loss is…
99e0d1d 
… outside of loss boundaries instead of the single batch loss
@grantbuster
cleaned up the tracking of epoch-running-avg loss data
923c009
@grantbuster
cleaned up train function and renamed loss diagnostics/data -> loss_d…
0c28cf6 
…etails
@grantbuster
added norm kwargs to generate and discriminate
9db4a7e
@grantbuster
remove history from saved params, instead just use history file in sa…
9051c3f 
…ved model dir. makes it more portable
@grantbuster grantbuster merged commit 627f3c6 into main Feb 14, 2022
@grantbuster grantbuster deleted the gb/fix_tests branch February 14, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnb32 bnb32 bnb32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grantbuster @bnb32