-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bnb/ws power law #165
Bnb/ws power law #165
Conversation
572d0f3
to
76777d0
Compare
…wind extrapolation data handler
76777d0
to
f3b0bd1
Compare
@grantbuster Main edits in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor thought on power law reference and alpha value
"""U wind component feature class with needed inputs method and compute | ||
method. Uses power law extrapolation to get values above surface | ||
|
||
https://en.wikipedia.org/wiki/Wind_profile_power_law |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on using this NOAA reference and set alpha=0.2 and put alpha as a class variable for transparency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Class var is a good idea. Why the disagreement between the alpha values though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure but NOAA is more defensible haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
our high school teachers would be so proud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our high school teachers were wrong. Wikipedia actually links to a paper. NOAA doesn't have a source for 0.2 that I can see?
tests/data/test_era5_co_2012.nc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder to be really intentional when adding big test files like this. Every file added is added forever and bloats the repo size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is trimmed for only needed vars but I misnamed it last merge.
input_files = [os.path.join(TEST_DATA_DIR, 'uas_test.nc')] | ||
|
||
with xr.open_mfdataset(input_files) as fh: | ||
u_100m = fh['uas'].values * 100**0.143 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you set alpha to class attr you can reference that here
No description provided.