Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sup3rWind examples #199

Merged
merged 7 commits into from
Mar 21, 2024
Merged

Sup3rWind examples #199

merged 7 commits into from
Mar 21, 2024

Conversation

bnb32
Copy link
Collaborator

@bnb32 bnb32 commented Mar 16, 2024

Basically the same as Sup3rCC examples.

castelao
castelao reviewed Mar 18, 2024
View reviewed changes
Copy link
Member

@castelao castelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much to add here. I think it was a good move to create _get_xr_dset() thus allowing a pipeline directly from an xr.Dataset without necessarily creating the netCDF.

sup3r/postprocessing/file_handling.py Show resolved Hide resolved
@bnb32 bnb32 merged commit abca254 into main Mar 21, 2024
6 checks passed
@bnb32 bnb32 deleted the bnb/dev branch March 21, 2024 19:49
github-actions bot pushed a commit that referenced this pull request Mar 21, 2024
@bnb32
Merge pull request #199 from NREL/bnb/dev
793019d 
Sup3rWind examples - Merging this since it is low stakes and referenced in slides that are about to be published.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castelao castelao castelao left review comments

@grantbuster grantbuster Awaiting requested review from grantbuster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnb32 @castelao