Bnb/fp output #41
Merged
Bnb/fp output #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bclassed for NETCDF.
…n fix in data handler parallel norm method.
grantbuster
requested changes
Jun 2, 2022
sup3r/pipeline/forward_pass.py
Outdated
| logger.info('Combining forward pass output for ' | ||
| f'{cls.file_info_logging(file_paths)}') | ||
| @classmethod | ||
| def write_output(cls, data, features, bottom_left_corner, |
There was a problem hiding this comment.
At some point we need to save meta data about the GAN used to generate this output.
…ctly. Added lat/lon/time interpolation to output handler.
|
@bnb32, the meta data interpolation still fails. This test should be a bare minimum acceptance criteria (feel free to add to the test suite): test_meta_interp.py.txt Also, can we make sure the preprocessing / post_processing modules both either have underscores or do not? Thats going to make importing a nightmare. |
|
Lol yeah I realized the underscore annoyance as well. Good test will add that thanks. |
…rom h5_output branch
grantbuster
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic netcdf output handling for forward pass results. Added some more parallelization for feature loading and normalization. Added new model configs for full production models. Forward pass test for fp -> netcdf -> fp included and working.