Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wake steering controller #26

Merged
merged 13 commits into from
Jan 31, 2024

Conversation

misi9170
Copy link
Collaborator

@misi9170 misi9170 commented Jan 5, 2024

Implements a simple lookup-table based wake steering controller, including the controller itself; an example using the Hercules FLORIS standin; and tests.

TO DO:

  • Check existing tests pass
  • Add example with plots
  • Add/update test for new controller
  • Remove previous stand-in controller
  • Update documentation on controllers, examples

Notes

Currently, yaw angles are set as a function of wind direction only (and not wind speed). In order to enable wind speed dependency, wind speeds should be provided from the simulator (AMR-wind, AMR-wind standin, FLORIS standin etc). As these are not yet available from AMR-wind, they have been left out of the standins for the time being and the wind speed is hard coded on lookup at 8 m/s.

Addresses #5

@misi9170
Copy link
Collaborator Author

misi9170 commented Jan 17, 2024

After some minor updates, the companion PR on Hercules is ready for review; I am requesting reviews now but will only merge this after the Hercules PR is merged.

@misi9170 misi9170 added enhancement New feature or request examples Changes to examples documentation Improvements or additions to documentation labels Jan 17, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice, we'll need to make more like this

Copy link
Collaborator

@paulf81 paulf81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you @misi9170

@misi9170 misi9170 merged commit f84938f into NREL:develop Jan 31, 2024
3 checks passed
@misi9170 misi9170 deleted the feature/wake-steering-control branch January 31, 2024 17:09
achenry pushed a commit to achenry/wind-hybrid-open-controller that referenced this pull request Apr 22, 2024
* Example added to start out.

* Renaming wake steering standin.

* Runs when df_yaw=None; working on rest of implementaiton.

* running, although many repotitions per time step.

* Runs as expected; going to pass external data.

* Finishing example, including plot.

* Add readme.

* Fix pytest, ruff.

* Remove obselete example.

* Update documentation.

* Require flasc as a dependency.

* Update to test wake steering lookup.

* Hercules units now fixed as kW.
@misi9170 misi9170 mentioned this pull request Jul 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request examples Changes to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants