ENH: only let channels which have a name into read/config list #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrakitin
reviewed
Feb 12, 2018
| active_channels.append(ch_name) | ||
|
|
||
| self.channels.read_attrs = list(active_channels) | ||
| self.channels.configuration_attrs = list(active_channels) |
There was a problem hiding this comment.
Is list needed in this case? It's already defined as list above
There was a problem hiding this comment.
Yes, if you just assigned then self.channels.read_attrs is self.channels.configuration_attrs would be True and appending or popping from one list would affect the other. That may actually be sensible in this case, but would be very surprising.
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
==========================================
+ Coverage 89.42% 89.44% +0.02%
==========================================
Files 51 51
Lines 7016 7049 +33
==========================================
+ Hits 6274 6305 +31
- Misses 742 744 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.