Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2][_commonspeckle] for xpcs_timepixel.py is there anything we can learn from this or should we delete #40

Open
ambarb opened this issue Oct 8, 2020 · 3 comments
Assignees
Labels
_commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) question V2 required to move towards share XPCS/speckle analysis for CHX/CSX

Comments

@ambarb
Copy link
Collaborator

ambarb commented Oct 8, 2020

@afluerasu said this was just a test of the detector to see what worked and that this is not used at CHX

Is there anything we can learn from this module to make the others more generic?

Should we set aside this module for future implementations of the LBNL TimePix for soft x-rays?

@ambarb ambarb added the question label Oct 8, 2020
@ambarb ambarb added _commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) V2 required to move towards share XPCS/speckle analysis for CHX/CSX labels Oct 8, 2020
@ambarb
Copy link
Collaborator Author

ambarb commented Oct 22, 2020

not deleting because using timepix for quantum.

@danielballan suggest to find the day this file was created and compare to chx_correlationp.py or chx_correlationc.py to see if we just need to get IO and put somewhere so we can interface.

@danielballan
Copy link
Contributor

This is a bigger mess than I had anticipated. The copy-pasting was not a one-time event, but rather a habit that spanned over multiple years. There are no short-cuts here other than line-by-line comparing each function.

@danielballan
Copy link
Contributor

(I had thought this split was the result of a one-time rush to make a specific experiment work that just never got cleaned up.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) question V2 required to move towards share XPCS/speckle analysis for CHX/CSX
Projects
None yet
Development

No branches or pull requests

3 participants