Cmu #173
Merged
Cmu #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is trial and error
Lots more Unicode chars need to be added along with lots more tests. There are 40 tests and 3 failures at the moment -- those all involve mmultiscripts which I haven't gotten to yet. I'm still working my way through the manual to add/refine rules. The manual is sometimes short on specifics, especially when it comes to when a grouping char is needed for 2D element children.
For drop numbers, I decided to make use of private space. It's cleaner that way (they are just like any other digit). This meant `BrailleChars(node, code)` needed to allow a string or node instead of just a node, so some changes around that. Up to 79/83 passing.
The tests required adding to unicode.yaml. That still needs *lots* more chars. 122/125 tests pass. There are still a few more obscure things to add tests for (e.g, modified primed variables and Roman Numerals), but pretty much all the normal things except tables seem to work modulo the missing characters. Added new definition: CMUFunctionNames
…ly definitiions. Added `scripted` and `modified`. Update rules accordingly.
This fixes example 3.3(3) Also some fixes with mmultiscripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.