Refactoring + Signal Processing and Code Reuse Improvements #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gitignore + requirements updated for incoming NumExpr dependency
Now supports more window types, with better documentation and logging. This change is fully backwards compatible.
Added documentation and error handling. Functionally identical to previous version.
No functional change.
Major changes: - Generalized FFT detectors using enumerations - Removed code made redundant by this generalization - Moved power scaling into the action instead of fft.py - Updated FFT method to leverage parallelization and be more agnostic about intended power scaling - Created power_analysis to hold some functions (power conversions for now, more later) - Updated documentation in lots of places - Updated M4s action based on fft.py changes (should yield the same results)
Now handles metadata creation from scratch when executing an action. Did not pull changes for single_freq_fft action yet.
New names are more specific, to distinguish from time domain detectors (implementation TBD). Also parameterized returned data type of apply_fft_detector (default functionality unchanged)
aromanielloNTIA
changed the title
Removed old instance variable, which should have been done when creating the is_complex method. Tests now pass again.
|
Closing draft to open new PR (so that changes are compared against the updated version of y_factor_cal_complete) |
|
That didn't work. The diffs are horribly messy because I manually merged recent commits from y_factor_cal_complete into this branch instead of actually merging them. Their Git history is different, so changes show up where there aren't actually changes. |
|
Closing this, moved PR to #25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(edited/removed) See #25