Use multiple Ray supervisor actors to process IQ in SEA action #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dboulware
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the number of Ray supervisor actors used for IQ processing in the SEA data product action, from 1 to 3. It also adds code which explicitly kills the actors after retrieving processed data. Manual garbage collection calls are also removed, which may have been causing issues when running in separate processes.
In testing (on seadog02), this has reduced the failure rate for the action runs. Without this patch, the failure rate is 20% on average. With this patch, the error rate is 8.5% on average. Segmentation faults and OverflowError still occur and should be addressed in the future.
Negligible impact has been observed on CPU usage, memory usage, and action runtime.