Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AS 3.1 and 3.2 #17

Open
rsutphin opened this issue Jan 3, 2012 · 3 comments
Open

Support AS 3.1 and 3.2 #17

rsutphin opened this issue Jan 3, 2012 · 3 comments

Comments

@rsutphin
Copy link
Contributor

rsutphin commented Jan 3, 2012

Aker's gemspec claims support for all 3.x versions of ActiveSupport. It is currently only tested in CI on 3.0.x, however.

Initial attempts at running Aker's test suite with AS 3.1.3 and 3.2.0.rc1 found no spec failures, but two cucumber failures of this form:

ActiveRecord::ConnectionNotEstablished (ActiveRecord::ConnectionNotEstablished)
./features/support/controllable_cas_server.rb:44:in `register_user'
./features/step_definitions/setup_steps.rb:38:in `block (2 levels) in <top (required)>'
./features/step_definitions/setup_steps.rb:37:in `each'
./features/step_definitions/setup_steps.rb:37:in `/^I have a CAS server that accepts these usernames and passwords:$/'
features/cas.feature:5:in `Given I have a CAS server that accepts these usernames and passwords:'

These appear to be test setup failures, rather than actual failures that would be encountered when using Aker with AS 3.1 or 3.2.

rsutphin added a commit that referenced this issue Jan 3, 2012
These won't be enabled in CI yet due to the problems outlined on #17.
wjdix pushed a commit to wjdix/aker that referenced this issue Apr 11, 2012
@wjdix
Copy link
Contributor

wjdix commented Apr 12, 2012

After updating rubycas-server, All tests and features pass with AS 3.1 and AS 3.2

@wjdix wjdix closed this as completed Apr 12, 2012
rsutphin added a commit that referenced this issue May 30, 2012
While the upstream merge and April 12 changes in the current master were
intended to make the test CAS server work with Rails 3.1+, they actually break
Aker's integrated tests on all ruby and activesupport versions.
@rsutphin rsutphin reopened this May 30, 2012
@rsutphin
Copy link
Contributor Author

The CI builds have been failing ever since the fixes for this were merged.

@rsutphin
Copy link
Contributor Author

Update: the CI build is now passing for all rubies on AS 3.0 and 3.1. It passes for JRuby and MRI 1.8.7 on AS 2.3, but not 1.9.2. I'm okay with this because the set of people using Rails 2.3 with Ruby 1.9.2 has got to be pretty close to empty at this point.

Neither 1.8.7 or 1.9.2 builds pass with AS 3.2, however, so I have not enabled 3.2 in CI.

rsutphin added a commit that referenced this issue Sep 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants