Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a mechanism to compare MDES versions #10

Closed
rsutphin opened this issue Apr 5, 2012 · 1 comment
Closed

Provide a mechanism to compare MDES versions #10

rsutphin opened this issue Apr 5, 2012 · 1 comment
Assignees
@rsutphin
Labels
feature

Comments

@rsutphin
Copy link
Contributor

rsutphin commented Apr 5, 2012

Add a differ that can report on changes between the computable representations of two MDES versions. It should consider:

  • New/removed tables
  • New/changed/removed variables
  • New/changed/removed types, including code lists
    • Code list changes must compare code/label pairs in both directions
@ghost ghost assigned rsutphin Apr 6, 2012
rsutphin added a commit that referenced this issue Mar 2, 2013
@rsutphin
Implement Variable#diff. Starting #10.
a7a97a1
rsutphin added a commit that referenced this issue Mar 2, 2013
@rsutphin
Implement TransmissionTable#diff. #10.
415b6e2 
Includes differences in the corresponding variables.
rsutphin added a commit that referenced this issue Mar 2, 2013
@rsutphin
Implement VariableType#diff. #10.
7929fc6 
Also extends Variable#diff to include Variable#type.
rsutphin added a commit that referenced this issue Mar 2, 2013
@rsutphin
Move CodeList and CodeListEntry out of VariableType. #10.
3a553fe 
Since CodeListEntry is going to be carrying more logic once #diff is
implemented on it, it makes sense to put it in a separate file.
rsutphin added a commit that referenced this issue Mar 2, 2013
@rsutphin
Implement CodeListEntry#diff. #10.
bdaed69 
Also extends VariableType#diff to include code list differences.
rsutphin added a commit that referenced this issue Mar 2, 2013
@rsutphin
Implement Specification#diff. #10
9f5466b
rsutphin added a commit that referenced this issue Mar 2, 2013
@rsutphin
Introduce concept of strict and not diffs. #10.
fa27a02 
The default (non-strict) diff attempts to only include meaningful
changes. It ignores:

* Changes to whitespace, punctuation, or case in code list labels
* Variable status changes which are not actionable
* The unused "global_value" and "master_cl" attributes on CodeListEntry

The strict diff includes all these things along with the meaningful
changes.
rsutphin added a commit that referenced this issue Mar 2, 2013
@rsutphin
CI's still going on 1.8.7. #10.
a4268ea
@rsutphin
Copy link
Contributor Author

rsutphin commented Mar 7, 2013

Specification#diff (and comparable methods at each level of the spec) provide a machine-readable structured difference. That's good enough for now.

@rsutphin rsutphin closed this as completed Mar 7, 2013
@rsutphin rsutphin mentioned this issue Mar 7, 2013
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsutphin rsutphin

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rsutphin