-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make surveyor install on Rails 4.0 #460
Conversation
Looks like the main entry point only loads the engine if Line 2 in d27bdda
|
Am working on this myself. Have all the rspec's passing - now on to getting a full rails 4 app to verify against. See https://github.com/ferrisoxide/surveyor on the develop branch. Very much a work in progress |
Cool @ferrisoxide - thanks for chiming in. Would be cool to hear some statements from the maintainers. |
Our group is hard at work on one of the apps that uses surveyor, and we haven't had a chance to take a look at this yet. Thanks for the contribution! |
I have added more Rails4 fixes to @ferrisoxide's work, which was a great start. The rspec tests now pass and we're down to a single deprecation warning. I opened a pull request back to his fork, so hopefully he can be a point of focus for Rails4 changes. If he opts not to, I'll do it. |
Hi @caboteria. I'd love to help out, but I'm not sure I can provide consistent support for the Rails 4 changes (and I don't want to disappoint anyone). But thank you for asking. I am planning on doing some extra work - mainly to get rid the requirement for the |
Thanks for getting the Rails4 ball rolling @ferrisoxide, I'll keep chipping away at it. If you get the protected_attribute stuff worked out, please send me a pull. |
+1 |
I'll have some time to work on the Rails 4 port next week. Sorry for the general slackness - just busy on other things. Good work @caboteria for pushing this along. |
@ferrisoxide and @caboteria thanks for your contributions! See the rails4 branch. |
However it doesn't work, as there seems to be a problem with formtastic or something... at least I can not run the migrations.
Cheers,
Tobi