Feature/rs 8539 add key flag to screener questions assisting #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k with the latest versions and updated bundler.
…ses to be created properly in Rails 4.2
… a question is given a 'correct' answer upon parsing.
…f sprockets so we stop getting errors and made it so we know to precompile the surveyor_all files.
…building this project.
…ead of sass as this worked.
…y import in the engine file as this breaks the configuration otherwise.
…xt section' buttons instead of assuming bootstrap classes.
… default which will get messed up if you edit a survey
…her or not all the mandatory questions which are triggered have been answered.
… model to the question model so it could be used in other places.
… adding skip logic to a section based on responses to questions to point to a target section to jump to.
… to fill out. In doing so added some tests for this method.
…nd just updated the method on 'response_set' to properly check for empty responses. Updated survey_section#complete? method to match this change. Updated tests to match this also.
…hods for questions and resposne sets which allow us to check if a response set is qualified.
…t section for survey sections which will allow for denoting that the survey should complete.
…n before validation so we can truly validate instead of the previous version where we could create a broken survey.
…ill have to upgrade specs to post 3.4.4 rspec.
…der when looking at a question. In doing so, updated some tests. Also updated some gem requirements to make tests run on my machine.
This includes removing sass and rabl, updating rspec, and removing unused specs. This gem is now primarily concerned with the models and does not include anything around the FE for taking surveys as that is provided by the rails-server.
Adds version numbers to the migration files in line with when they were created. Adds required: false to belongs_to associations which are not required and updates those which are required to be explicit so we do not rely on the config being set up properly in an app. Removes a spec which doesn't run any more due to removed assets as the FE concerns were removed.
* RS-4292 Updates to allow specs to run in 5.1 Adds version numbers to the migration files in line with when they were created. Adds required: false to belongs_to associations which are not required and updates those which are required to be explicit so we do not rely on the config being set up properly in an app. Removes a spec which doesn't run any more due to removed assets as the FE concerns were removed. * CHORE Remove unused files and deprecation warnings Update Rakefile, database cleaner gem, and parser_spec to remove warnings. Remove locales files and reference to empty directories in generators. Removed some should matchers in specs.
…or-version-2.4.10-gems RS-4458 fix version and gem sync with UI app
- fixes missed rspec deprecations - adds some UI credits given our hacking it up - drops rails < 4.2.10
…by-2.5 RS-4458 require ruby 2.5
doesn’t fix everything but gets us in a better spot and with some frozen string wins
…-pre-rubocop RS-4476 rubocop to match UI app rules (3.2.1)
also lint some of the models in this horrorshow
Co-authored-by: Jeff Baxendale <jeffbax@users.noreply.github.com>
…-v3.3.0 RS-4476 upgrade to rails 5.2.6 and ruby 2.6.7
…f-for-question-answer-association Feature/rs 7111 added inverse_of for has_many :answers association in question_methods.rb
PLUCS2
deleted the
feature/RS-8539-add-key-flag-to-screener-questions-assisting
branch
PLUCS2
restored the
feature/RS-8539-add-key-flag-to-screener-questions-assisting
branch
PLUCS2
deleted the
feature/RS-8539-add-key-flag-to-screener-questions-assisting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8539 on RS - necessary for adding screener questions. Linked to feature/RS-8539-add-key-flag-to-screener-questions PR on RS.
This PR will add a migration to add a column to the questions table - boolean - and allow the param to be passed forward.