Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database column name "study_id" is misleading #5

Closed
alena456 opened this issue May 5, 2021 · 5 comments · Fixed by #7
Closed

Database column name "study_id" is misleading #5

alena456 opened this issue May 5, 2021 · 5 comments · Fixed by #7
Labels
enhancement New feature or request

Comments

@alena456
Copy link
Contributor

alena456 commented May 5, 2021

Description

The field name "study_id" which is used for identification of study participants is misleading and should be renamed. It sould indicate that this value represents a subject identifier.

Study systems usually reference the following terms:

  • SubjectID (integer) as database reference for table relations
  • SubjectNumber (text) for a generated or assigned identifier for study participants that is used to identify subjects within a study center

ToDo

The name of the field should be updated in the code and all relating documentation.

@alena456 alena456 added the enhancement New feature or request label May 5, 2021
@alena456
Copy link
Contributor Author

I propose to use "subject_id" as reference in the database and code to have one consistent name.

@alena456
Copy link
Contributor Author

@lenzch Should we also change the reference "AppId" used for the cTransfer object to "SubjectID" in order to make the value more relatable?

@alena456
Copy link
Contributor Author

alena456 commented May 10, 2021

@lenzch do you have a preference regarding the naming of the corresponding database table? It is currently called "STUDYUSER". I would propose to rename it to "STUDYPARTICIPANT".
Also I would like to rename the "user" route accordingly to "/subject" or "/participant".

alena456 pushed a commit that referenced this issue May 10, 2021
#5 (Database column name "study_id" is misleading)
@lenzch
Copy link
Contributor

lenzch commented May 11, 2021

@alena456 I think naming the table "STUDYPARTICIPANT" and the primary key "subject_id" is fine.
And the route should be named "/participant". Thank you.

@alena456
Copy link
Contributor Author

Merged changes after validation #7

@alena456 alena456 linked a pull request May 19, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants