-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
年(年度)指定の追加 #557
Merged
Merged
年(年度)指定の追加 #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imaimai17468
requested changes
Apr 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
実装ありがとう!
方針はいい感じで動作も問題なし!
- BudgetはYear型を使っているのでこのままで大丈夫
- それ以外は、purchaseOrderに対するレビューを参考に全体的に修正して欲しい!
- あとコンフリクトも解消してほしい
KazumaSun
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Apr 28, 2023
imaimai17468
approved these changes
Apr 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応Issue
resolve #503
概要
セレクトボックスで指定された年(年度)の情報のみを表示させるようにした.
予算ページ,購入申請ページ,購入報告ページでは,合計金額にも反映するようにした.
画面スクリーンショット等
URL
スクリーンショット
例(「学内募金」)
テスト項目
「予算」,「学内募金」,「購入申請」,「購入報告」,「協賛活動」,「協賛企業」のページで年(年度)指定で表示内容が切り替えられるか
「予算」,「学内募金」,「購入申請」,「購入報告」の合計金額が年(年度)ごとに変更されるか確認.
なお,「学内募金」では,test3@test.com(財務局長権限)によるチェックが完了しているものの合計金額とした.
備考