Add Subgraph op to define & reuse parts of larger graphs
#334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlhigley
changed the title
Subgraph operator for defining and re-using parts of larger graphs
karlhigley
changed the title
Subgraph operator for defining and re-using parts of larger graphsSubgraph op for defining and re-using parts of larger graphs
karlhigley
changed the title
Subgraph op for defining and re-using parts of larger graphsSubgraph op to define and reuse parts of larger graphs
karlhigley
changed the title
Subgraph op to define and reuse parts of larger graphsSubgraph op to define & reuse parts of larger graphs
Documentation preview |
oliverholworthy
approved these changes
Jun 2, 2023
merlin/dag/executors.py
Outdated
| @@ -417,7 +417,10 @@ def fit(self, dataset: Dataset, graph: Graph, refit=True): | |||
| if not graph.output_schema: | |||
| graph.construct_schema(dataset.schema) | |||
|
|
|||
| ddf = dataset.to_ddf(columns=graph._input_columns()) | |||
| # if isinstance(dataset, Dataset): | |||
There was a problem hiding this comment.
do we need to keep this comment around?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
Subgraphop that can contain a graph of operators and can be fetched fromGraphthat contains it by name (e.g.graph.subgraph("user")).