Change Outputs and SharedOuputs return type to tuple #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI MESSAGE: [891937]: BUILD STARTED |
|
CI MESSAGE: [891937]: BUILD FAILED |
Signed-off-by: Serge Panev <spanev@nvidia.com>
Kh4L
force-pushed
the
output_return_tuple
branch
from
c55b1ac
to
1939bdd
Compare
|
!build |
Kh4L
changed the title
|
CI MESSAGE: [895582]: BUILD STARTED |
|
CI MESSAGE: [895582]: BUILD PASSED |
jantonguirao
approved these changes
Sep 12, 2019
awolant
approved these changes
Sep 12, 2019
00liujj
pushed a commit
to 00liujj/DALI
that referenced
this pull request
Oct 10, 2019
Signed-off-by: Serge Panev <spanev@nvidia.com> Signed-off-by: Jianjun Liu <00liujj@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need this PR?
Python's
tuplecontainer type is immutable, therefore, a better fit for the returned TensorLists.What happened in this PR?
We cast the output to tuple with pybind in backend_impl.
We keep
py::listduring the construction: it is a good container of the list for element heterogeneous types (Backend).