Fix Transpose operator when data shape has irrelevant dimensions (i.e. dimension of size 1) #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jantonguirao
force-pushed
the
fix_transpose_op
branch
3 times, most recently
from
6cce67d
to
f229c16
Compare
jantonguirao
changed the title
|
!build |
|
CI MESSAGE: [893930]: BUILD STARTED |
|
CI MESSAGE: [893930]: BUILD FAILED |
jantonguirao
force-pushed
the
fix_transpose_op
branch
from
f229c16
to
6162a06
Compare
Kh4L
reviewed
Sep 10, 2019
jantonguirao
force-pushed
the
fix_transpose_op
branch
from
6162a06
to
65e744c
Compare
|
!build |
|
CI MESSAGE: [894085]: BUILD STARTED |
|
CI MESSAGE: [894085]: BUILD PASSED |
jantonguirao
force-pushed
the
fix_transpose_op
branch
from
65e744c
to
ffccbd7
Compare
|
!build |
|
CI MESSAGE: [895257]: BUILD STARTED |
…400, 1), (1, 200, 400, 3)) Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
fix_transpose_op
branch
from
ffccbd7
to
cfd1eec
Compare
|
!build |
|
CI MESSAGE: [895306]: BUILD STARTED |
|
CI MESSAGE: [895306]: BUILD PASSED |
mzient
reviewed
Sep 11, 2019
| for (int i = 0; i < rank; ++i) { | ||
| new_dims[i] = dims[rank - 1 - i]; | ||
| new_perm[i] = rank - 1 - perm[rank - 1 - i]; | ||
| dims[i] = dims_copy[rank - 1 - i]; |
|
!build |
|
CI MESSAGE: [895771]: BUILD STARTED |
mzient
reviewed
Sep 11, 2019
| } | ||
| return {std::move(new_dims), std::move(new_perm)}; | ||
|
|
||
| std::unordered_map<int, int> idx_map; |
There was a problem hiding this comment.
Possible improvement: this could be just a vector.
mzient
approved these changes
Sep 11, 2019
jantonguirao
force-pushed
the
fix_transpose_op
branch
from
a2fd67e
to
c0f71bf
Compare
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
fix_transpose_op
branch
from
c0f71bf
to
e1c34d9
Compare
|
!build |
|
CI MESSAGE: [895806]: BUILD STARTED |
|
CI MESSAGE: [895806]: BUILD PASSED |
00liujj
pushed a commit
to 00liujj/DALI
that referenced
this pull request
Oct 10, 2019
…IA#1244) * Fix Transpose operator to accept data shapes including 1 (e.g. (200, 400, 1), (1, 200, 400, 3)) Signed-off-by: Joaquin Anton <janton@nvidia.com> Signed-off-by: Jianjun Liu <00liujj@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joaquin Anton janton@nvidia.com
Why we need this PR?
Fixes a bug in Transpose operator when the shape of the input contains a 1 (e.g.
[800, 600, 1],[1, 500, 400, 3])What happened in this PR?
Add changes to detect a special case and remove any dimension that is equal to 1 before invoking cuTT. The permutation order is also adjusted to reflect the flattened shape.
JIRA TASK: N/A