Add additional_decode_surfaces parameter to videoreader #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Sansanwal <asansanwal@nvidia.com>
a-sansanwal
force-pushed
the
additional_decode_surfaces
branch
from
2b50d03
to
d287407
Compare
a-sansanwal
changed the title
jantonguirao
approved these changes
Oct 24, 2019
JanuszL
approved these changes
Oct 24, 2019
|
!build |
|
CI MESSAGE: [959571]: BUILD STARTED |
|
CI MESSAGE: [959571]: BUILD PASSED |
rbetz
pushed a commit
to rbetz/DALI
that referenced
this pull request
Oct 28, 2019
Signed-off-by: Abhishek Sansanwal <asansanwal@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need this PR?
Pick one
Adds
additional_decode_surfacesparameter to VideoReader.Also reduces device memory usage as mentioned in VideoReader use too much device memory? What should I do? #1372 (comment)
What happened in this PR?
By default we use min_num_decode_surfaces + 2. If however using older API/driver the nvdec api does not return min_num_decode_surfaces, we use 20 surfaces as before.
The parameter can be used to control memory usage.
Tested with videoreader benchmark Add benchmark for VideoReader and L1 tests for the same #1173. Before and after results were within tolerance of each other.
JIRA TASK: [DALI-XXXX]