Fix input tiling in arithmetic ops #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
CI MESSAGE: [964626]: BUILD STARTED |
The offset for input pointer in tile was calculated using the sizeof of output type instead of input type. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
awolant
approved these changes
Oct 28, 2019
|
CI MESSAGE: [964769]: BUILD STARTED |
JanuszL
approved these changes
Oct 28, 2019
|
CI MESSAGE: [964769]: BUILD PASSED |
jantonguirao
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offset for input pointer in tile was calculated
using the sizeof of output type instead of input type.
Signed-off-by: Krzysztof Lecki klecki@nvidia.com
Why we need this PR?
Fix the above mentioned bug
What happened in this PR?
Now tile offsets are calculated based on sizeof of the input type
The bug was fixed.
Test was adjusted to force calculation of at least 2 tiles (assuming current tiling sizes).
CI.
No.
JIRA TASK: [DALI-XXXX]