Improve support for labels in VideoReader. #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanuszL
reviewed
Nov 26, 2019
JanuszL
reviewed
Nov 26, 2019
JanuszL
reviewed
Nov 26, 2019
JanuszL
reviewed
Nov 26, 2019
Signed-off-by: Abhishek Sansanwal <asansanwal@nvidia.com>
Signed-off-by: Abhishek Sansanwal <asansanwal@nvidia.com>
a-sansanwal
force-pushed
the
videoreader_file_list_clips_label
branch
from
db906b0
to
018e096
Compare
|
CI MESSAGE: [1015170]: BUILD STARTED |
a-sansanwal
changed the title
JanuszL
reviewed
Dec 3, 2019
JanuszL
reviewed
Dec 3, 2019
JanuszL
reviewed
Dec 3, 2019
JanuszL
reviewed
Dec 3, 2019
JanuszL
reviewed
Dec 3, 2019
JanuszL
reviewed
Dec 3, 2019
JanuszL
reviewed
Dec 3, 2019
JanuszL
reviewed
Dec 3, 2019
a-sansanwal
force-pushed
the
videoreader_file_list_clips_label
branch
from
018e096
to
bae68fb
Compare
JanuszL
approved these changes
Dec 5, 2019
awolant
approved these changes
Dec 5, 2019
a-sansanwal
force-pushed
the
videoreader_file_list_clips_label
branch
from
bae68fb
to
b8920a7
Compare
|
CI MESSAGE: [1020646]: BUILD STARTED |
Description: Added gtest cases for enable_frame_num, enable_timestamps, file_list_frame_num and labels to parts of a video. Signed-off-by: Abhishek Sansanwal <asansanwal@nvidia.com>
a-sansanwal
force-pushed
the
videoreader_file_list_clips_label
branch
from
b8920a7
to
f9d31a2
Compare
|
CI MESSAGE: [1020778]: BUILD STARTED |
|
CI MESSAGE: [1020823]: BUILD STARTED |
|
CI MESSAGE: [1020823]: BUILD FAILED |
|
CI MESSAGE: [1020823]: BUILD PASSED |
|
CI MESSAGE: [1020823]: BUILD FAILED |
|
CI MESSAGE: [1020823]: BUILD PASSED |
a-sansanwal
force-pushed
the
videoreader_file_list_clips_label
branch
from
f9d31a2
to
af864d7
Compare
|
CI MESSAGE: [1024370]: BUILD STARTED |
|
CI MESSAGE: [1024370]: BUILD FAILED |
|
CI MESSAGE: [1024549]: BUILD STARTED |
|
CI MESSAGE: [1024549]: BUILD PASSED |
Signed-off-by: Abhishek Sansanwal <asansanwal@nvidia.com>
a-sansanwal
force-pushed
the
videoreader_file_list_clips_label
branch
from
18b9d34
to
89f4b6f
Compare
This was referenced Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abhishek Sansanwal asansanwal@nvidia.com
Why we need this PR?
Pick one
Add's support for applying labels to part parts of a video. Either using timestmap or frame number through file_list.
Add's support for outputting frame_numbers and timestamps of the decoded frames using
enable_frame_numandenable_timestampsparametersAddresses #940, #1458, #753, #666
What happened in this PR?
Explain solution of the problem, new feature added.
Two additional columns can be provided as input using the plaintxt file passed through file_list argument.
The two values are interpreted as start/end timestamps. If they are skipped the label is applied to the entire video. If
file_list_frame_numis set to true, then the timestamps are interpreted as frame numbers instead of timestamps.What was changed, added, removed?
Parsing the input file_list was modified.
Logic to generate sequences was changed to apply labels to sequences that fall within the start/end range specified.
What is most important part that reviewers should focus on?
filesystem::get_file_label_pair() in video_loader.cc
PrepareMetadataImpl() in video_loader.h
Was this PR tested? How?
Tested using gtest test app.Using
gtest_filter=VideoReaderTest.StartEndLabels:VideoReaderTest.FrameLabels:VideoReaderTest.FrameLabelsWithFileListFrameNum:VideoReaderTest.TimestampLabelsWere docs and examples updated, if necessary?
Docs updated.
Needs NVIDIA/DALI_extra#35 for test cases
Future to-do ?
Support reading input from csv files instead of plaintext files.
JIRA TASK: [DALI-XXXX]