Use different stream base for different videos. #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add some test for it as well? |
a-sansanwal
added a commit
to a-sansanwal/DALI_extra
that referenced
this pull request
Dec 22, 2019
Description: Used for testing NVIDIA/DALI#1592 Signed-off-by: Abhishek Sansanwal <asansanwal@nvidia.com>
Signed-off-by: Abhishek Sansanwal <asansanwal@nvidia.com>
a-sansanwal
force-pushed
the
videoreader_multiple_stream_base_fix
branch
from
8e716e4
to
865f81c
Compare
a-sansanwal
changed the title
|
CI MESSAGE: [1044086]: BUILD STARTED |
|
CI MESSAGE: [1044086]: BUILD FAILED |
a-sansanwal
force-pushed
the
videoreader_multiple_stream_base_fix
branch
from
865f81c
to
d6c7b98
Compare
|
CI MESSAGE: [1044125]: BUILD STARTED |
|
CI MESSAGE: [1044125]: BUILD FAILED |
a-sansanwal
force-pushed
the
videoreader_multiple_stream_base_fix
branch
from
d6c7b98
to
dc0372c
Compare
|
CI MESSAGE: [1044338]: BUILD STARTED |
|
CI MESSAGE: [1044338]: BUILD PASSED |
a-sansanwal
added a commit
to a-sansanwal/DALI_extra
that referenced
this pull request
Dec 26, 2019
Description: Used for testing NVIDIA/DALI#1592 Signed-off-by: Abhishek Sansanwal <asansanwal@nvidia.com>
JanuszL
approved these changes
Dec 27, 2019
jantonguirao
pushed a commit
to NVIDIA/DALI_extra
that referenced
this pull request
Dec 30, 2019
Description: Used for testing NVIDIA/DALI#1592 Signed-off-by: Abhishek Sansanwal <asansanwal@nvidia.com>
jantonguirao
requested changes
Dec 30, 2019
Signed-off-by: Abhishek Sansanwal <asansanwal@nvidia.com>
a-sansanwal
force-pushed
the
videoreader_multiple_stream_base_fix
branch
from
dc0372c
to
a29058e
Compare
jantonguirao
approved these changes
Dec 30, 2019
|
!build |
|
CI MESSAGE: [1051621]: BUILD STARTED |
|
CI MESSAGE: [1051621]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abhishek Sansanwal asansanwal@nvidia.com
Why we need this PR?
We were using the time_base from the first video for all the videos.
If a dataset contained videos with different frame rates, we would fail to decode as mentioned in The pixels generated from DALI are all 0 #1583
TODO: add testcases.
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
[ Explain solution of the problem, a new feature added here. ]
[ Describe here what was changed, added, removed. ]
[ Describe here what is the most important part that reviewers should focus on. ]
[ Describe here if and how this PR is tested. ]
[ Describe here if documentation and examples were updated. ]
JIRA TASK: [Use DALI-XXXX or NA]