Add bitwise operators: &, |, ^ #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support bitwise operators in backend and python wrapper. Bitwise operators follow the same type promotions as other binary operators. The type promotions are applied first. The are disallowed for non-integral types. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [1040475]: BUILD STARTED |
JanuszL
approved these changes
Dec 19, 2019
awolant
approved these changes
Dec 19, 2019
|
CI MESSAGE: [1040475]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need this PR?
What happened in this PR?
Support bitwise operators in backend and python wrapper.
Bitwise operators follow the same type promotions
as other binary operators.
The type promotions are applied first.
The are disallowed for non-integral types.
expressions
Key points relevant for the review:
Validation and testing:
Test were updated.
WIll do in a follow up.
JIRA TASK: [required by 1190]